You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/04 19:07:44 UTC
[GitHub] [beam] johnjcasey opened a new pull request, #17268: [BEAM-10529] enable nullable for kafkaIO xlang
johnjcasey opened a new pull request, #17268:
URL: https://github.com/apache/beam/pull/17268
Leverage the new nullable coder to enable the nullable coder for kafkaIO xlang
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1087912121
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #17268:
URL: https://github.com/apache/beam/pull/17268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1092339298
Ah, I should have done "squash and merge" here :(
For future reference, please merge commits into one or few commits for which you care about maintaining commit history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1092338409
Thanks. LGTM.
We should verify that the WriteToKafka can write null keys as well (though I don't see an explicit change needed here to support that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1092884667
Ah, will do that in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1087912120
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1087912119
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1087912123
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #17268:
URL: https://github.com/apache/beam/pull/17268#issuecomment-1087969755
R: @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org