You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/02 03:47:26 UTC

[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe

busbey commented on a change in pull request #2180:
URL: https://github.com/apache/hbase/pull/2180#discussion_r464027188



##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -69,7 +69,7 @@
     Compression.Algorithm.NONE, Compression.Algorithm.GZ
   };
 
-  protected Configuration conf;
+  protected final Configuration conf;

Review comment:
       we make use of this across our internal subclasses of `HBaseCommonTestingUtility` so if we made it private instead of protected we'd need to add an accessor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org