You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/08 09:46:34 UTC

[GitHub] [hbase] petersomogyi commented on a change in pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

petersomogyi commented on a change in pull request #2854:
URL: https://github.com/apache/hbase/pull/2854#discussion_r553842516



##########
File path: pom.xml
##########
@@ -1341,6 +1341,14 @@
                     <bannedImport>org.glassfish.jersey.**</bannedImport>
                   </bannedImports>
                 </restrictImports>
+                <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+                  <includeTestCode>true</includeTestCode>
+                  <commentLineBufferSize>512</commentLineBufferSize>
+                  <reason>Use RestrictedApi annotation in error prone instead</reason>

Review comment:
       HBASE-24640 replaced VisibleForTesting with IA.Private annotation. The `reason` in this `restrictImports` should recommend the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org