[GitHub] [incubator-superset] rusackas commented on a change in pull request #10837: feat: move ace-editor and mathjs to async modules

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10837:
URL: https://github.com/apache/incubator-superset/pull/10837#discussion_r488286150



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
##########
@@ -37,7 +37,7 @@ describe('Datasource control', () => {
     cy.get('#datasource_menu').click();
     cy.get('a').contains('Edit Datasource').click();
     // create new metric
-    cy.get('button').contains('Add Item').click();
+    cy.get('table button').contains('Add Item', { timeout: 10000 }).click();

Review comment:
       FWIW, I'm planning to go through and replace lots of these cypress DOM selectors with `data-test` attribute selectors, so things are more explicit and easier to maintain test integrity/auditability. If you have feelings on that, let me know :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org