You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/10/31 01:04:45 UTC
[GitHub] [incubator-druid] gianm commented on a change in pull request
#8794: Startup scripts: verify Java 8 (exactly),
improve port/java verification messages.
gianm commented on a change in pull request #8794: Startup scripts: verify Java 8 (exactly), improve port/java verification messages.
URL: https://github.com/apache/incubator-druid/pull/8794#discussion_r340923713
##########
File path: examples/bin/verify-java
##########
@@ -20,14 +20,35 @@
use strict;
use warnings;
+sub fail_check {
+ my ($current_version) = @_;
+ my $current_version_text =
+ $current_version ? " Your current version is: $current_version." : "";
Review comment:
Good idea, I added `Make sure that "java" is installed and on your PATH.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org