You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by Gayan Gunarathne <ga...@wso2.com> on 2015/09/17 17:03:01 UTC

Application ID length validation

Added the logic to validate the application ID length.This is because we
are using the application ID as a Kubernetes service name which supports
up-to 24 characters.

But I could enable the application ID validation length to 20 as
integration test are failed due to integration test samples application ID
is greater than 20.Thus I set the max_length constant to 40 for the moment
and push the changes to the Stratos-4.1.x.

Will change the integration test samples with shorter application ID and
will update the application ID max length to 20.

Thanks,
Gayan

-- 

Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>

Re: Application ID length validation

Posted by Imesh Gunaratne <im...@apache.org>.

May be we could add a label containing application id to the pods and
services.

On Friday, September 18, 2015, Dinithi De Silva <di...@wso2.com> wrote:

> As per the offline discussion, we will revert back to the previous way of
> handling the pod ids and service ids. So we will use service IDs as
> service1, service2 ... serviceN and the applicationId will not append to
> this.
>
> On Thu, Sep 17, 2015 at 10:39 PM, Gayan Gunarathne <gayang@wso2.com
> <javascript:_e(%7B%7D,'cvml','gayang@wso2.com');>> wrote:
>
>> Idea for using the application ID as a service name to clearly
>> distinguish the Kubernetes service against the application ID.If we are
>> using other unique identifier, we won't be identify service belongs to the
>> application.
>>
>> OTOH we use application ID to identify the application and IMO we can
>> have a meaningful name with in the length of 20 characters.
>>
>> Thanks,
>> Gayan
>>
>> On Thu, Sep 17, 2015 at 8:58 PM, Akila Ravihansa Perera <
>> ravihansa@wso2.com <javascript:_e(%7B%7D,'cvml','ravihansa@wso2.com');>>
>> wrote:
>>
>>> +1 decoupling application id and kub8 service name. What if we
>>> repeatedly query the existing service names and increment the seq no until
>>> an available service name is found? This is what we do when generating pod
>>> names.
>>>
>>> On Thu, Sep 17, 2015 at 8:40 PM, Pubudu Gunatilaka <pubudug@wso2.com
>>> <javascript:_e(%7B%7D,'cvml','pubudug@wso2.com');>> wrote:
>>>
>>>> Hi Gayan,
>>>>
>>>> Can't we limit the Kubernetes service name rather than limiting the
>>>> application id. If we are deploying multiple applications, it would be
>>>> better if we can have meaningful name for the application ids. If we are
>>>> going to limit the kubernetes service name, we may have to come up with
>>>> another solution for that. We may not able to append the application id for
>>>> that.
>>>>
>>>> Thank you!
>>>>
>>>> On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <gayang@wso2.com
>>>> <javascript:_e(%7B%7D,'cvml','gayang@wso2.com');>> wrote:
>>>>
>>>>> Added the logic to validate the application ID length.This is because
>>>>> we are using the application ID as a Kubernetes service name which supports
>>>>> up-to 24 characters.
>>>>>
>>>>> But I could enable the application ID validation length to 20 as
>>>>> integration test are failed due to integration test samples application ID
>>>>> is greater than 20.Thus I set the max_length constant to 40 for the moment
>>>>> and push the changes to the Stratos-4.1.x.
>>>>>
>>>>> Will change the integration test samples with shorter application ID
>>>>> and will update the application ID max length to 20.
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>> --
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>> Committer & PMC Member, Apache Stratos
>>>>> email : gayang@wso2.com
>>>>> <javascript:_e(%7B%7D,'cvml','gayang@wso2.com');>  | mobile : +94
>>>>> 775030545 <%2B94%20766819985>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> *Pubudu Gunatilaka*
>>>> Software Engineer
>>>> WSO2, Inc.: http://wso2.com
>>>> lean.enterprise.middleware
>>>> mobile:  +94 77 4078049
>>>>
>>>
>>>
>>>
>>> --
>>> Akila Ravihansa Perera
>>> WSO2 Inc.;  http://wso2.com/
>>>
>>> Blog: http://ravihansa3000.blogspot.com
>>>
>>
>>
>>
>> --
>>
>> Gayan Gunarathne
>> Technical Lead, WSO2 Inc. (http://wso2.com)
>> Committer & PMC Member, Apache Stratos
>> email : gayang@wso2.com <javascript:_e(%7B%7D,'cvml','gayang@wso2.com');>
>> | mobile : +94 775030545 <%2B94%20766819985>
>>
>>
>>
>
>
>
> --
> *Dinithi De Silva*
> Associate Software Engineer, WSO2 Inc.
> m:+94716667655 | e:dinithis@wso2.com
> <javascript:_e(%7B%7D,'cvml','dinithis@wso2.com');> | w: www.wso2.com
> | a: #20, Palm Grove, Colombo 03
>


-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Re: Application ID length validation

Posted by Dinithi De Silva <di...@wso2.com>.

As per the offline discussion, we will revert back to the previous way of
handling the pod ids and service ids. So we will use service IDs as
service1, service2 ... serviceN and the applicationId will not append to
this.

On Thu, Sep 17, 2015 at 10:39 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Idea for using the application ID as a service name to clearly distinguish
> the Kubernetes service against the application ID.If we are using other
> unique identifier, we won't be identify service belongs to the application.
>
> OTOH we use application ID to identify the application and IMO we can have
> a meaningful name with in the length of 20 characters.
>
> Thanks,
> Gayan
>
> On Thu, Sep 17, 2015 at 8:58 PM, Akila Ravihansa Perera <
> ravihansa@wso2.com> wrote:
>
>> +1 decoupling application id and kub8 service name. What if we repeatedly
>> query the existing service names and increment the seq no until an
>> available service name is found? This is what we do when generating pod
>> names.
>>
>> On Thu, Sep 17, 2015 at 8:40 PM, Pubudu Gunatilaka <pu...@wso2.com>
>> wrote:
>>
>>> Hi Gayan,
>>>
>>> Can't we limit the Kubernetes service name rather than limiting the
>>> application id. If we are deploying multiple applications, it would be
>>> better if we can have meaningful name for the application ids. If we are
>>> going to limit the kubernetes service name, we may have to come up with
>>> another solution for that. We may not able to append the application id for
>>> that.
>>>
>>> Thank you!
>>>
>>> On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Added the logic to validate the application ID length.This is because
>>>> we are using the application ID as a Kubernetes service name which supports
>>>> up-to 24 characters.
>>>>
>>>> But I could enable the application ID validation length to 20 as
>>>> integration test are failed due to integration test samples application ID
>>>> is greater than 20.Thus I set the max_length constant to 40 for the moment
>>>> and push the changes to the Stratos-4.1.x.
>>>>
>>>> Will change the integration test samples with shorter application ID
>>>> and will update the application ID max length to 20.
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>> --
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>> Committer & PMC Member, Apache Stratos
>>>> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> *Pubudu Gunatilaka*
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean.enterprise.middleware
>>> mobile:  +94 77 4078049
>>>
>>
>>
>>
>> --
>> Akila Ravihansa Perera
>> WSO2 Inc.;  http://wso2.com/
>>
>> Blog: http://ravihansa3000.blogspot.com
>>
>
>
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>
>
>



-- 
*Dinithi De Silva*
Associate Software Engineer, WSO2 Inc.
m:+94716667655 | e:dinithis@wso2.com | w: www.wso2.com
| a: #20, Palm Grove, Colombo 03

Re: Application ID length validation

Posted by Gayan Gunarathne <ga...@wso2.com>.

Idea for using the application ID as a service name to clearly distinguish
the Kubernetes service against the application ID.If we are using other
unique identifier, we won't be identify service belongs to the application.

OTOH we use application ID to identify the application and IMO we can have
a meaningful name with in the length of 20 characters.

Thanks,
Gayan

On Thu, Sep 17, 2015 at 8:58 PM, Akila Ravihansa Perera <ra...@wso2.com>
wrote:

> +1 decoupling application id and kub8 service name. What if we repeatedly
> query the existing service names and increment the seq no until an
> available service name is found? This is what we do when generating pod
> names.
>
> On Thu, Sep 17, 2015 at 8:40 PM, Pubudu Gunatilaka <pu...@wso2.com>
> wrote:
>
>> Hi Gayan,
>>
>> Can't we limit the Kubernetes service name rather than limiting the
>> application id. If we are deploying multiple applications, it would be
>> better if we can have meaningful name for the application ids. If we are
>> going to limit the kubernetes service name, we may have to come up with
>> another solution for that. We may not able to append the application id for
>> that.
>>
>> Thank you!
>>
>> On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Added the logic to validate the application ID length.This is because we
>>> are using the application ID as a Kubernetes service name which supports
>>> up-to 24 characters.
>>>
>>> But I could enable the application ID validation length to 20 as
>>> integration test are failed due to integration test samples application ID
>>> is greater than 20.Thus I set the max_length constant to 40 for the moment
>>> and push the changes to the Stratos-4.1.x.
>>>
>>> Will change the integration test samples with shorter application ID and
>>> will update the application ID max length to 20.
>>>
>>> Thanks,
>>> Gayan
>>>
>>> --
>>>
>>> Gayan Gunarathne
>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>> Committer & PMC Member, Apache Stratos
>>> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>>>
>>>
>>>
>>
>>
>>
>> --
>>
>> *Pubudu Gunatilaka*
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean.enterprise.middleware
>> mobile:  +94 77 4078049
>>
>
>
>
> --
> Akila Ravihansa Perera
> WSO2 Inc.;  http://wso2.com/
>
> Blog: http://ravihansa3000.blogspot.com
>



-- 

Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>

Re: Application ID length validation

Posted by Akila Ravihansa Perera <ra...@wso2.com>.

+1 decoupling application id and kub8 service name. What if we repeatedly
query the existing service names and increment the seq no until an
available service name is found? This is what we do when generating pod
names.

On Thu, Sep 17, 2015 at 8:40 PM, Pubudu Gunatilaka <pu...@wso2.com> wrote:

> Hi Gayan,
>
> Can't we limit the Kubernetes service name rather than limiting the
> application id. If we are deploying multiple applications, it would be
> better if we can have meaningful name for the application ids. If we are
> going to limit the kubernetes service name, we may have to come up with
> another solution for that. We may not able to append the application id for
> that.
>
> Thank you!
>
> On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>> Added the logic to validate the application ID length.This is because we
>> are using the application ID as a Kubernetes service name which supports
>> up-to 24 characters.
>>
>> But I could enable the application ID validation length to 20 as
>> integration test are failed due to integration test samples application ID
>> is greater than 20.Thus I set the max_length constant to 40 for the moment
>> and push the changes to the Stratos-4.1.x.
>>
>> Will change the integration test samples with shorter application ID and
>> will update the application ID max length to 20.
>>
>> Thanks,
>> Gayan
>>
>> --
>>
>> Gayan Gunarathne
>> Technical Lead, WSO2 Inc. (http://wso2.com)
>> Committer & PMC Member, Apache Stratos
>> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>>
>>
>>
>
>
>
> --
>
> *Pubudu Gunatilaka*
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean.enterprise.middleware
> mobile:  +94 77 4078049
>



-- 
Akila Ravihansa Perera
WSO2 Inc.;  http://wso2.com/

Blog: http://ravihansa3000.blogspot.com

Re: Application ID length validation

Posted by Pubudu Gunatilaka <pu...@wso2.com>.

Hi Gayan,

Can't we limit the Kubernetes service name rather than limiting the
application id. If we are deploying multiple applications, it would be
better if we can have meaningful name for the application ids. If we are
going to limit the kubernetes service name, we may have to come up with
another solution for that. We may not able to append the application id for
that.

Thank you!

On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Added the logic to validate the application ID length.This is because we
> are using the application ID as a Kubernetes service name which supports
> up-to 24 characters.
>
> But I could enable the application ID validation length to 20 as
> integration test are failed due to integration test samples application ID
> is greater than 20.Thus I set the max_length constant to 40 for the moment
> and push the changes to the Stratos-4.1.x.
>
> Will change the integration test samples with shorter application ID and
> will update the application ID max length to 20.
>
> Thanks,
> Gayan
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>
>
>



-- 

*Pubudu Gunatilaka*
Software Engineer
WSO2, Inc.: http://wso2.com
lean.enterprise.middleware
mobile:  +94 77 4078049