You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/08 14:55:33 UTC
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1127: MINIFICPP-1601 Add example flow configurations
szaszm commented on a change in pull request #1127:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1127#discussion_r666266339
##########
File path: examples/puts3_config.yml
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+MiNiFi Config Version: 3
+Flow Controller:
+ name: MiNiFi Flow
+Processors:
+- Properties:
+ Input Directory: /tmp/input
+ auto-terminated relationships list: []
+ class: org.apache.nifi.processors.standard.GetFile
+ id: bfd376a8-c845-453b-9f74-4cf6f3a95e74
+ name: GetFile
+ penalization period: 30 sec
+ run duration nanos: 0
+ scheduling period: 2 sec
+ scheduling strategy: TIMER_DRIVEN
+ yield period: 1 sec
+- Properties:
+ Access Key: test_access_key
+ Bucket: test_bucket
+ Secret Key: test_secret
+ auto-terminated relationships list:
+ - failure
+ class: org.apache.nifi.processors.standard.PutS3Object
+ id: 8c9e2512-e814-4b73-ac5c-f33753332128
+ name: PutS3Object
+ penalization period: 30 sec
+ run duration nanos: 0
+ scheduling period: 1 sec
+ scheduling strategy: TIMER_DRIVEN
+ yield period: 1 sec
+- Properties:
+ Directory: /tmp/output
+ Directory Permissions: '777'
+ Permissions: '777'
+ auto-terminated relationships list:
+ - success
+ - failure
+ class: org.apache.nifi.processors.standard.PutFile
+ id: d7dbc3af-ee24-4bc0-8c63-90e0f3185e0f
+ name: PutFile
+ penalization period: 30 sec
+ run duration nanos: 0
+ scheduling period: 1 sec
+ scheduling strategy: EVENT_DRIVEN
+ yield period: 1 sec
+Connections:
+- destination id: 8c9e2512-e814-4b73-ac5c-f33753332128
+ drop empty: 'false'
+ name: cc62a4a5-3a43-4725-8d05-d0b3e65d1ee6
Review comment:
More descriptive names are a good practice. For connections, the usual source-name/relationship/destination-name is fine. For processors, something like "Upload to S3 test_bucket" is preferrable over "PutS3Object".
##########
File path: examples/puts3_config.yml
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+MiNiFi Config Version: 3
+Flow Controller:
+ name: MiNiFi Flow
+Processors:
+- Properties:
+ Input Directory: /tmp/input
+ auto-terminated relationships list: []
+ class: org.apache.nifi.processors.standard.GetFile
+ id: bfd376a8-c845-453b-9f74-4cf6f3a95e74
+ name: GetFile
+ penalization period: 30 sec
+ run duration nanos: 0
+ scheduling period: 2 sec
+ scheduling strategy: TIMER_DRIVEN
+ yield period: 1 sec
+- Properties:
+ Access Key: test_access_key
+ Bucket: test_bucket
+ Secret Key: test_secret
+ auto-terminated relationships list:
+ - failure
+ class: org.apache.nifi.processors.standard.PutS3Object
+ id: 8c9e2512-e814-4b73-ac5c-f33753332128
+ name: PutS3Object
+ penalization period: 30 sec
+ run duration nanos: 0
+ scheduling period: 1 sec
+ scheduling strategy: TIMER_DRIVEN
+ yield period: 1 sec
+- Properties:
+ Directory: /tmp/output
+ Directory Permissions: '777'
+ Permissions: '777'
+ auto-terminated relationships list:
+ - success
+ - failure
+ class: org.apache.nifi.processors.standard.PutFile
Review comment:
I find this layout confusing. Consider following the format of `CONFIGURE.md`:
```
- name: GetFile
id: 471deef6-2a6e-4a7d-912a-81cc17e3a206
class: org.apache.nifi.processors.standard.GetFile
max concurrent tasks: 1
scheduling strategy: TIMER_DRIVEN
scheduling period: 1 sec
penalization period: 30 sec
yield period: 1 sec
run duration nanos: 0
auto-terminated relationships list:
Properties:
Input Directory: /tmp/getfile
Keep Source File: true
```
Also, I would exclude unnecessary settings from the example config, like "scheduling period" in case of EVENT_DRIVEN strategy. Or yield period, unless it has some significance.
##########
File path: examples/pdh_config.yml
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+MiNiFi Config Version: 3
+Flow Controller:
+ name: MiNiFi Flow
+Processors:
+- id: 2f2a3b47-f5ba-49f6-82b5-bc1c86b96e27
+ name: ConsumeWindowsEventLog
+ class: org.apache.nifi.minifi.processors.PerformanceDataMonitor
Review comment:
There is some inconsistency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org