[jira] [Commented] (THRIFT-3158) TBase#deepCopy should return T

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546559#comment-14546559 ] 

ASF GitHub Bot commented on THRIFT-3158:
----------------------------------------

GitHub user roshan opened a pull request:

    https://github.com/apache/thrift/pull/499

    THRIFT-3158 Make deepcopy return T

    All TBase types return themselves, so this should be fine. I suppose that without https://github.com/apache/thrift/pull/498 this is not strictly backwards-compatible since `T` currently only extends `TBase<?,?>`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/roshan/thrift THRIFT-3158_deepcopy_returns_T

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #499
    
----
commit 4a0f01279722bdf4fa2f5e29e369c02a7148cc7e
Author: Roshan George <ro...@arjie.com>
Date:   2015-05-16T04:56:15Z

    Make deepcopy return T

----


> TBase<T,F>#deepCopy should return T
> -----------------------------------
>
>                 Key: THRIFT-3158
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3158
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.2
>            Reporter: Roshan George
>
> This is a bit of an annoyance. Every Thrift object returns itself on being deepCopy'd, but if you use the TBase interface you can't rely on that and you're forced to cast.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)