You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/05/19 09:34:11 UTC
Re: mesos git commit: Removed deprecated annotation for values in a
protobuf enum.
Do we need to be source-compatible with protobuf 2.5? If so, why?
Neil
On Wed, May 18, 2016 at 11:15 PM, <al...@apache.org> wrote:
> Repository: mesos
> Updated Branches:
> refs/heads/master b7e50fe8b -> 4248b3c3a
>
>
> Removed deprecated annotation for values in a protobuf enum.
>
> Support for deprecated annotation for enums was added in protobuf 2.6.
> Since we should be compatible with 2.5, refrain from using the
> feature.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/4248b3c3
> Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/4248b3c3
> Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/4248b3c3
>
> Branch: refs/heads/master
> Commit: 4248b3c3a1cbfdf3bef2bebc401cca55407f2b87
> Parents: b7e50fe
> Author: Alexander Rukletsov <al...@apache.org>
> Authored: Wed May 18 23:14:47 2016 +0200
> Committer: Alexander Rukletsov <al...@apache.org>
> Committed: Wed May 18 23:14:47 2016 +0200
>
> ----------------------------------------------------------------------
> include/mesos/authorizer/authorizer.proto | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/mesos/blob/4248b3c3/include/mesos/authorizer/authorizer.proto
> ----------------------------------------------------------------------
> diff --git a/include/mesos/authorizer/authorizer.proto b/include/mesos/authorizer/authorizer.proto
> index b0d9f79..911a227 100644
> --- a/include/mesos/authorizer/authorizer.proto
> +++ b/include/mesos/authorizer/authorizer.proto
> @@ -61,8 +61,8 @@ enum Action {
> // TODO(zhitao): Remove the following two actions at the end of
> // the deprecation cycle which started with 0.29. They will be
> // fully replaced by `UPDATE_QUOTA_WITH_ROLE`.
> - SET_QUOTA_WITH_ROLE = 8 [deprecated = true];
> - DESTROY_QUOTA_WITH_PRINCIPAL = 9 [deprecated = true];
> + SET_QUOTA_WITH_ROLE = 8; // [deprecated = true];
> + DESTROY_QUOTA_WITH_PRINCIPAL = 9; // [deprecated = true];
>
> UPDATE_WEIGHTS_WITH_ROLE = 10;
> GET_ENDPOINT_WITH_PATH = 11;
>
Re: mesos git commit: Removed deprecated annotation for values in a
protobuf enum.
Posted by Alex Rukletsov <al...@mesosphere.com>.
Some 3rdparty components (e.g. modules) still rely on 2.5.1. We've advised
them to upgrade and will restore the deprecated annotation soon.
On Thu, May 19, 2016 at 11:34 AM, Neil Conway <ne...@gmail.com> wrote:
> Do we need to be source-compatible with protobuf 2.5? If so, why?
>
> Neil
>
> On Wed, May 18, 2016 at 11:15 PM, <al...@apache.org> wrote:
> > Repository: mesos
> > Updated Branches:
> > refs/heads/master b7e50fe8b -> 4248b3c3a
> >
> >
> > Removed deprecated annotation for values in a protobuf enum.
> >
> > Support for deprecated annotation for enums was added in protobuf 2.6.
> > Since we should be compatible with 2.5, refrain from using the
> > feature.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/4248b3c3
> > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/4248b3c3
> > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/4248b3c3
> >
> > Branch: refs/heads/master
> > Commit: 4248b3c3a1cbfdf3bef2bebc401cca55407f2b87
> > Parents: b7e50fe
> > Author: Alexander Rukletsov <al...@apache.org>
> > Authored: Wed May 18 23:14:47 2016 +0200
> > Committer: Alexander Rukletsov <al...@apache.org>
> > Committed: Wed May 18 23:14:47 2016 +0200
> >
> > ----------------------------------------------------------------------
> > include/mesos/authorizer/authorizer.proto | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/mesos/blob/4248b3c3/include/mesos/authorizer/authorizer.proto
> > ----------------------------------------------------------------------
> > diff --git a/include/mesos/authorizer/authorizer.proto
> b/include/mesos/authorizer/authorizer.proto
> > index b0d9f79..911a227 100644
> > --- a/include/mesos/authorizer/authorizer.proto
> > +++ b/include/mesos/authorizer/authorizer.proto
> > @@ -61,8 +61,8 @@ enum Action {
> > // TODO(zhitao): Remove the following two actions at the end of
> > // the deprecation cycle which started with 0.29. They will be
> > // fully replaced by `UPDATE_QUOTA_WITH_ROLE`.
> > - SET_QUOTA_WITH_ROLE = 8 [deprecated = true];
> > - DESTROY_QUOTA_WITH_PRINCIPAL = 9 [deprecated = true];
> > + SET_QUOTA_WITH_ROLE = 8; // [deprecated = true];
> > + DESTROY_QUOTA_WITH_PRINCIPAL = 9; // [deprecated = true];
> >
> > UPDATE_WEIGHTS_WITH_ROLE = 10;
> > GET_ENDPOINT_WITH_PATH = 11;
> >
>