[GitHub] [flink] JingsongLi commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner
URL: https://github.com/apache/flink/pull/10068#discussion_r341906917
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/LazyBinaryFormat.java
 ##########
 @@ -68,28 +72,43 @@ public void setJavaObject(T javaObject) {
 
 	@Override
 	public MemorySegment[] getSegments() {
-		ensureMaterialized();
+		if (segments == null) {
+			throw new IllegalStateException("Lazy Binary Format was not materialized");
+		}
 		return segments;
 	}
 
 	@Override
 	public int getOffset() {
-		ensureMaterialized();
+		if (segments == null) {
+			throw new IllegalStateException("Lazy Binary Format was not materialized");
+		}
 		return offset;
 	}
 
 	@Override
 	public int getSizeInBytes() {
-		ensureMaterialized();
+		if (segments == null) {
+			throw new IllegalStateException("Lazy Binary Format was not materialized");
+		}
 		return sizeInBytes;
 	}
 
 	/**
 	 * Ensure we have materialized binary format.
 	 */
-	public void ensureMaterialized() {
+	public final void ensureMaterialized(TypeSerializer<T> serializer) {
 		if (segments == null) {
-			materialize();
+			try {
+				Binary binary = materialize(serializer);
+				this.offset = binary.offset;
+				this.sizeInBytes = binary.sizeInBytes;
+
+				// segments must be set last as this variable tells if the object was materialized
 
 Review comment:
   If we just store a `Binary`, that will be safer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services