You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/10/22 11:51:03 UTC
[commons-logging] branch master updated (f0ec0ab -> cdb9ef5)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
from f0ec0ab Fix up GHA badges
new 23206cb Use Java 1.4 API
new 34c37d6 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-logging
new 5cbd34c Format tweaks
new cdb9ef5 Remove unused parameter from private method
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/commons/logging/impl/LogFactoryImpl.java | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
[commons-logging] 04/04: Remove unused parameter from private method
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit cdb9ef5ce45c9166ed2db639b178ff0d0844e93f
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Oct 22 07:50:59 2023 -0400
Remove unused parameter from private method
---
src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
index fad95fe..8399d22 100644
--- a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
+++ b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
@@ -457,7 +457,7 @@ public class LogFactoryImpl extends LogFactory {
// handleFlawedDiscovery will determine whether this is a fatal
// problem or not. If it is fatal, then a LogConfigurationException
// will be thrown.
- handleFlawedDiscovery(logAdapterClassName, currentCL, t);
+ handleFlawedDiscovery(logAdapterClassName, t);
}
if (currentCL == null) {
@@ -979,16 +979,11 @@ public class LogFactoryImpl extends LogFactory {
*
* @param logAdapterClassName is the class name of the Log implementation
* that could not be instantiated. Cannot be {@code null}.
- *
- * @param classLoader is the classloader that we were trying to load the
- * logAdapterClassName from when the exception occurred.
- *
* @param discoveryFlaw is the Throwable created by the classloader
*
* @throws LogConfigurationException ALWAYS
*/
private void handleFlawedDiscovery(final String logAdapterClassName,
- final ClassLoader classLoader, // USED?
final Throwable discoveryFlaw) {
if (isDiagnosticsEnabled()) {
[commons-logging] 03/04: Format tweaks
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit 5cbd34c654fbae2af1a10fd8b248149aaf4579ff
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Oct 22 07:50:05 2023 -0400
Format tweaks
---
src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
index 55d2ba6..fad95fe 100644
--- a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
+++ b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
@@ -1001,7 +1001,7 @@ public class LogFactoryImpl extends LogFactory {
// Ok, the lib is there but while trying to create a real underlying
// logger something failed in the underlying lib; display info about
// that if possible.
- final InvocationTargetException ite = (InvocationTargetException)discoveryFlaw;
+ final InvocationTargetException ite = (InvocationTargetException) discoveryFlaw;
final Throwable cause = ite.getTargetException();
if (cause != null) {
logDiagnostic("... InvocationTargetException: " +
@@ -1009,7 +1009,7 @@ public class LogFactoryImpl extends LogFactory {
cause.getLocalizedMessage());
if (cause instanceof ExceptionInInitializerError) {
- final ExceptionInInitializerError eiie = (ExceptionInInitializerError)cause;
+ final ExceptionInInitializerError eiie = (ExceptionInInitializerError) cause;
final Throwable cause2 = eiie.getCause();
if (cause2 != null) {
final StringWriter sw = new StringWriter();
[commons-logging] 02/04: Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-logging
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit 34c37d6e7da81a97bf9a8ea02f6537efedbedc3d
Merge: 23206cb f0ec0ab
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Oct 22 07:49:10 2023 -0400
Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-logging
README.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[commons-logging] 01/04: Use Java 1.4 API
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit 23206cb098fb48e4e0700df7c22dc6606109e060
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Oct 22 07:48:38 2023 -0400
Use Java 1.4 API
---
src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
index c01bc20..55d2ba6 100644
--- a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
+++ b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
@@ -1010,7 +1010,7 @@ public class LogFactoryImpl extends LogFactory {
if (cause instanceof ExceptionInInitializerError) {
final ExceptionInInitializerError eiie = (ExceptionInInitializerError)cause;
- final Throwable cause2 = eiie.getException();
+ final Throwable cause2 = eiie.getCause();
if (cause2 != null) {
final StringWriter sw = new StringWriter();
cause2.printStackTrace(new PrintWriter(sw, true));