You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2012/03/24 00:39:29 UTC
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237297#comment-13237297 ]
Hadoop QA commented on ZOOKEEPER-1432:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519743/ZOOKEEPER-1432.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//console
This message is automatically generated.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira