You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by mu...@gmail.com on 2008/11/15 20:42:36 UTC
Convention plugin recap - proposal
On our super long convention thread, we got to the agreement that in order
to move convention out of the sandbox, there should be a way to run both
plugins side by side, so backward compatibility could be possible. The
remaining issue to make that happen was to implement "multiple unknown
handler", for which I uploaded a new patch here (against trunk):
http://jira.opensymphony.com/browse/XW-640
(http://fisheye6.atlassian.com/cru/DEMO-19)
that creates an extension point for unknown handlers manager, instead of
some ugly static classes I wrote before. We also agreed to include
convention after 2.1 was released, but based on how long releases
take(hoping to change that soon), I propose that we move convention out of
trunk for the next 2.1 release so it will be available when 2.1 goes GA,
and not 1 or 2 years after that.
@Rainer, @Rene: could you guys take a look at the new patch? That thing was
a pain to merge being so old, the new one should merge fine.
regards
musachy
Re: Convention plugin recap - proposal
Posted by Rene Gielen <gi...@it-neering.net>.
me as well
Rainer Hermanns schrieb:
> Musachy,
>
> I'll have a look in the next couple of days.
> I'll contact you on IRC during the week.
>
> cheers,
> Rainer
>
>> On our super long convention thread, we got to the agreement that in order
>> to move convention out of the sandbox, there should be a way to run both
>> plugins side by side, so backward compatibility could be possible. The
>> remaining issue to make that happen was to implement "multiple unknown
>> handler", for which I uploaded a new patch here (against trunk):
>>
>> http://jira.opensymphony.com/browse/XW-640
>> (http://fisheye6.atlassian.com/cru/DEMO-19)
>>
>> that creates an extension point for unknown handlers manager, instead of
>> some ugly static classes I wrote before. We also agreed to include
>> convention after 2.1 was released, but based on how long releases
>> take(hoping to change that soon), I propose that we move convention out of
>> trunk for the next 2.1 release so it will be available when 2.1 goes GA,
>> and not 1 or 2 years after that.
>>
>> @Rainer, @Rene: could you guys take a look at the new patch? That thing
>> was
>> a pain to merge being so old, the new one should merge fine.
>>
>> regards
>> musachy
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy,
I'll have a look in the next couple of days.
I'll contact you on IRC during the week.
cheers,
Rainer
> On our super long convention thread, we got to the agreement that in order
> to move convention out of the sandbox, there should be a way to run both
> plugins side by side, so backward compatibility could be possible. The
> remaining issue to make that happen was to implement "multiple unknown
> handler", for which I uploaded a new patch here (against trunk):
>
> http://jira.opensymphony.com/browse/XW-640
> (http://fisheye6.atlassian.com/cru/DEMO-19)
>
> that creates an extension point for unknown handlers manager, instead of
> some ugly static classes I wrote before. We also agreed to include
> convention after 2.1 was released, but based on how long releases
> take(hoping to change that soon), I propose that we move convention out of
> trunk for the next 2.1 release so it will be available when 2.1 goes GA,
> and not 1 or 2 years after that.
>
> @Rainer, @Rene: could you guys take a look at the new patch? That thing
> was
> a pain to merge being so old, the new one should merge fine.
>
> regards
> musachy
>
--
Rainer Hermanns
aixcept
Willibrordstraße 82
52134 Herzogenrath - Germany
w: http://aixcept.de/
t: +49 - 2406 - 979 22 11
f: +49 - 2406 - 979 22 13
m: +49 - 170 - 343 29 12
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by vikofvan <vi...@yahoo.com>.
Can you please add convention as a module in the plugins/pom.xml It is not
compiling at the moment. Thanks.
Vik
Musachy Barroso wrote:
>
> On our super long convention thread, we got to the agreement that in order
> to move convention out of the sandbox, there should be a way to run both
> plugins side by side, so backward compatibility could be possible. The
> remaining issue to make that happen was to implement "multiple unknown
> handler", for which I uploaded a new patch here (against trunk):
>
> http://jira.opensymphony.com/browse/XW-640
> (http://fisheye6.atlassian.com/cru/DEMO-19)
>
> that creates an extension point for unknown handlers manager, instead of
> some ugly static classes I wrote before. We also agreed to include
> convention after 2.1 was released, but based on how long releases
> take(hoping to change that soon), I propose that we move convention out of
> trunk for the next 2.1 release so it will be available when 2.1 goes GA,
> and not 1 or 2 years after that.
>
> @Rainer, @Rene: could you guys take a look at the new patch? That thing
> was
> a pain to merge being so old, the new one should merge fine.
>
> regards
> musachy
>
>
--
View this message in context: http://www.nabble.com/Convention-plugin-recap---proposal-tp20518854p21058601.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by dusty <du...@yahoo.com>.
Woot! Very nice work on pusing this through Musachy!! I didn't even
realize it happened. I rebuilt my Mac and went to the sandbox to rebuild
convention and poof it was gone. I was very excited.
Musachy Barroso wrote:
>
> done
>
> On Tue, Dec 16, 2008 at 2:49 PM, Rainer Hermanns <he...@aixcept.de>
> wrote:
>> +1
>> thanks a lot for taking care :)
>>
>> cheers,
>> Rainer
>>> The Multiple Unknown Handlers patch was merged into xwork and struts
>>> trunks. Now we can move convention plugin out of the sanbox. Last call
>>> for objections :) (2.1 build coming soon)
>>>
>>> musachy
>>>
>>> On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <mu...@gmail.com>
>>> wrote:
>>>> I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
>>>> annoying empty lines from the diff. Crucible seems to have a bug, and
>>>> even
>>>> when I uncheck files from the "Patch" section, it keeps them in the
>>>> review
>>>> (take note Don :) )
>>>>
>>>> http://fisheye6.atlassian.com/cru/DEMO-21
>>>>
>>>> musachy
>>>>
>>>> On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
>>>>>
>>>>> On our super long convention thread, we got to the agreement that in
>>>>> order
>>>>> to move convention out of the sandbox, there should be a way to run
>>>>> both
>>>>> plugins side by side, so backward compatibility could be possible. The
>>>>> remaining issue to make that happen was to implement "multiple unknown
>>>>> handler", for which I uploaded a new patch here (against trunk):
>>>>>
>>>>> http://jira.opensymphony.com/browse/XW-640
>>>>> (http://fisheye6.atlassian.com/cru/DEMO-19)
>>>>>
>>>>> that creates an extension point for unknown handlers manager, instead
>>>>> of
>>>>> some ugly static classes I wrote before. We also agreed to include
>>>>> convention after 2.1 was released, but based on how long releases
>>>>> take(hoping to change that soon), I propose that we move convention
>>>>> out
>>>>> of
>>>>> trunk for the next 2.1 release so it will be available when 2.1 goes
>>>>> GA, and
>>>>> not 1 or 2 years after that.
>>>>>
>>>>> @Rainer, @Rene: could you guys take a look at the new patch? That
>>>>> thing
>>>>> was a pain to merge being so old, the new one should merge fine.
>>>>>
>>>>> regards
>>>>> musachy
>>>>
>>>>
>>>> --
>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>>
>>>
>>>
>>>
>>> --
>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> --
>> Rainer Hermanns
>> aixcept
>> Willibrordstraße 82
>> 52134 Herzogenrath - Germany
>> w: http://aixcept.de/
>> t: +49 - 2406 - 979 22 11
>> f: +49 - 2406 - 979 22 13
>> m: +49 - 170 - 343 29 12
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/Convention-plugin-recap---proposal-tp20518854p21130612.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by Musachy Barroso <mu...@gmail.com>.
done
On Tue, Dec 16, 2008 at 2:49 PM, Rainer Hermanns <he...@aixcept.de> wrote:
> +1
> thanks a lot for taking care :)
>
> cheers,
> Rainer
>> The Multiple Unknown Handlers patch was merged into xwork and struts
>> trunks. Now we can move convention plugin out of the sanbox. Last call
>> for objections :) (2.1 build coming soon)
>>
>> musachy
>>
>> On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <mu...@gmail.com>
>> wrote:
>>> I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
>>> annoying empty lines from the diff. Crucible seems to have a bug, and
>>> even
>>> when I uncheck files from the "Patch" section, it keeps them in the
>>> review
>>> (take note Don :) )
>>>
>>> http://fisheye6.atlassian.com/cru/DEMO-21
>>>
>>> musachy
>>>
>>> On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
>>>>
>>>> On our super long convention thread, we got to the agreement that in
>>>> order
>>>> to move convention out of the sandbox, there should be a way to run
>>>> both
>>>> plugins side by side, so backward compatibility could be possible. The
>>>> remaining issue to make that happen was to implement "multiple unknown
>>>> handler", for which I uploaded a new patch here (against trunk):
>>>>
>>>> http://jira.opensymphony.com/browse/XW-640
>>>> (http://fisheye6.atlassian.com/cru/DEMO-19)
>>>>
>>>> that creates an extension point for unknown handlers manager, instead
>>>> of
>>>> some ugly static classes I wrote before. We also agreed to include
>>>> convention after 2.1 was released, but based on how long releases
>>>> take(hoping to change that soon), I propose that we move convention out
>>>> of
>>>> trunk for the next 2.1 release so it will be available when 2.1 goes
>>>> GA, and
>>>> not 1 or 2 years after that.
>>>>
>>>> @Rainer, @Rene: could you guys take a look at the new patch? That thing
>>>> was a pain to merge being so old, the new one should merge fine.
>>>>
>>>> regards
>>>> musachy
>>>
>>>
>>> --
>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>
>>
>>
>>
>> --
>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> --
> Rainer Hermanns
> aixcept
> Willibrordstraße 82
> 52134 Herzogenrath - Germany
> w: http://aixcept.de/
> t: +49 - 2406 - 979 22 11
> f: +49 - 2406 - 979 22 13
> m: +49 - 170 - 343 29 12
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by Rainer Hermanns <he...@aixcept.de>.
+1
thanks a lot for taking care :)
cheers,
Rainer
> The Multiple Unknown Handlers patch was merged into xwork and struts
> trunks. Now we can move convention plugin out of the sanbox. Last call
> for objections :) (2.1 build coming soon)
>
> musachy
>
> On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <mu...@gmail.com>
> wrote:
>> I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
>> annoying empty lines from the diff. Crucible seems to have a bug, and
>> even
>> when I uncheck files from the "Patch" section, it keeps them in the
>> review
>> (take note Don :) )
>>
>> http://fisheye6.atlassian.com/cru/DEMO-21
>>
>> musachy
>>
>> On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
>>>
>>> On our super long convention thread, we got to the agreement that in
>>> order
>>> to move convention out of the sandbox, there should be a way to run
>>> both
>>> plugins side by side, so backward compatibility could be possible. The
>>> remaining issue to make that happen was to implement "multiple unknown
>>> handler", for which I uploaded a new patch here (against trunk):
>>>
>>> http://jira.opensymphony.com/browse/XW-640
>>> (http://fisheye6.atlassian.com/cru/DEMO-19)
>>>
>>> that creates an extension point for unknown handlers manager, instead
>>> of
>>> some ugly static classes I wrote before. We also agreed to include
>>> convention after 2.1 was released, but based on how long releases
>>> take(hoping to change that soon), I propose that we move convention out
>>> of
>>> trunk for the next 2.1 release so it will be available when 2.1 goes
>>> GA, and
>>> not 1 or 2 years after that.
>>>
>>> @Rainer, @Rene: could you guys take a look at the new patch? That thing
>>> was a pain to merge being so old, the new one should merge fine.
>>>
>>> regards
>>> musachy
>>
>>
>> --
>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
Rainer Hermanns
aixcept
Willibrordstraße 82
52134 Herzogenrath - Germany
w: http://aixcept.de/
t: +49 - 2406 - 979 22 11
f: +49 - 2406 - 979 22 13
m: +49 - 170 - 343 29 12
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by James Holmes <ja...@jamesholmes.com>.
+1
Let's get 2.1 to GA!
On Tue, Dec 16, 2008 at 12:50 PM, Musachy Barroso <mu...@gmail.com> wrote:
> The Multiple Unknown Handlers patch was merged into xwork and struts
> trunks. Now we can move convention plugin out of the sanbox. Last call
> for objections :) (2.1 build coming soon)
>
> musachy
>
> On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <mu...@gmail.com>
> wrote:
> > I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
> > annoying empty lines from the diff. Crucible seems to have a bug, and
> even
> > when I uncheck files from the "Patch" section, it keeps them in the
> review
> > (take note Don :) )
> >
> > http://fisheye6.atlassian.com/cru/DEMO-21
> >
> > musachy
> >
> > On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
> >>
> >> On our super long convention thread, we got to the agreement that in
> order
> >> to move convention out of the sandbox, there should be a way to run both
> >> plugins side by side, so backward compatibility could be possible. The
> >> remaining issue to make that happen was to implement "multiple unknown
> >> handler", for which I uploaded a new patch here (against trunk):
> >>
> >> http://jira.opensymphony.com/browse/XW-640
> >> (http://fisheye6.atlassian.com/cru/DEMO-19)
> >>
> >> that creates an extension point for unknown handlers manager, instead of
> >> some ugly static classes I wrote before. We also agreed to include
> >> convention after 2.1 was released, but based on how long releases
> >> take(hoping to change that soon), I propose that we move convention out
> of
> >> trunk for the next 2.1 release so it will be available when 2.1 goes GA,
> and
> >> not 1 or 2 years after that.
> >>
> >> @Rainer, @Rene: could you guys take a look at the new patch? That thing
> >> was a pain to merge being so old, the new one should merge fine.
> >>
> >> regards
> >> musachy
> >
> >
> > --
> > "Hey you! Would you help me to carry the stone?" Pink Floyd
> >
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Convention plugin recap - proposal
Posted by Musachy Barroso <mu...@gmail.com>.
The Multiple Unknown Handlers patch was merged into xwork and struts
trunks. Now we can move convention plugin out of the sanbox. Last call
for objections :) (2.1 build coming soon)
musachy
On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <mu...@gmail.com> wrote:
> I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
> annoying empty lines from the diff. Crucible seems to have a bug, and even
> when I uncheck files from the "Patch" section, it keeps them in the review
> (take note Don :) )
>
> http://fisheye6.atlassian.com/cru/DEMO-21
>
> musachy
>
> On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
>>
>> On our super long convention thread, we got to the agreement that in order
>> to move convention out of the sandbox, there should be a way to run both
>> plugins side by side, so backward compatibility could be possible. The
>> remaining issue to make that happen was to implement "multiple unknown
>> handler", for which I uploaded a new patch here (against trunk):
>>
>> http://jira.opensymphony.com/browse/XW-640
>> (http://fisheye6.atlassian.com/cru/DEMO-19)
>>
>> that creates an extension point for unknown handlers manager, instead of
>> some ugly static classes I wrote before. We also agreed to include
>> convention after 2.1 was released, but based on how long releases
>> take(hoping to change that soon), I propose that we move convention out of
>> trunk for the next 2.1 release so it will be available when 2.1 goes GA, and
>> not 1 or 2 years after that.
>>
>> @Rainer, @Rene: could you guys take a look at the new patch? That thing
>> was a pain to merge being so old, the new one should merge fine.
>>
>> regards
>> musachy
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Convention plugin recap - proposal
Posted by Musachy Barroso <mu...@gmail.com>.
I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the
annoying empty lines from the diff. Crucible seems to have a bug, and even
when I uncheck files from the "Patch" section, it keeps them in the review
(take note Don :) )
http://fisheye6.atlassian.com/cru/DEMO-21
musachy
On Sat, Nov 15, 2008 at 2:42 PM, <mu...@gmail.com> wrote:
> On our super long convention thread, we got to the agreement that in order
> to move convention out of the sandbox, there should be a way to run both
> plugins side by side, so backward compatibility could be possible. The
> remaining issue to make that happen was to implement "multiple unknown
> handler", for which I uploaded a new patch here (against trunk):
>
> http://jira.opensymphony.com/browse/XW-640 (
> http://fisheye6.atlassian.com/cru/DEMO-19)
>
> that creates an extension point for unknown handlers manager, instead of
> some ugly static classes I wrote before. We also agreed to include
> convention after 2.1 was released, but based on how long releases
> take(hoping to change that soon), I propose that we move convention out of
> trunk for the next 2.1 release so it will be available when 2.1 goes GA, and
> not 1 or 2 years after that.
>
> @Rainer, @Rene: could you guys take a look at the new patch? That thing was
> a pain to merge being so old, the new one should merge fine.
>
> regards
> musachy
--
"Hey you! Would you help me to carry the stone?" Pink Floyd