You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/02/21 20:23:28 UTC
[GitHub] activemq-artemis pull request #1883: Couple of small fixes
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1883
Couple of small fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1883
----
commit 777f0dd24ef5dcd5c178ce49b90b2b8df06546fe
Author: Justin Bertram <jb...@...>
Date: 2018-02-21T18:10:40Z
NO-JIRA comments to clarify Travis 'script' command
commit ad9163c2976491a51a3ca8df9df237cddc26131d
Author: Justin Bertram <jb...@...>
Date: 2018-02-21T20:22:34Z
NO-JIRA fix AlignedJournalImplTest intermittent failure
----
---
[GitHub] activemq-artemis pull request #1883: Couple of small fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1883
---
[GitHub] activemq-artemis pull request #1883: Couple of small fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1883#discussion_r169775676
--- Diff: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/AlignedJournalImplTest.java ---
@@ -1010,6 +1012,9 @@ public void testReclaimAfterRollabck() throws Exception {
journalImpl.forceMoveNextFile();
+ // wait for the previous call to forceMoveNextFile() to complete
+ assertTrue(Wait.waitFor(() -> factory.listFiles("tt").size() == COUNT + 3, 2000, 50));
--- End diff --
I can't believe it! :) nice catch!! 👍
---