You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/05 15:25:42 UTC
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
andrijapanicsb opened a new issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836
@weizhouapache @GabrielBrascher @wido - can those of you using Basic zone with SG, please test Primate against Basic Zone? Advanced zone stuff was extensively tested by many of us (me, Daan, etc) - so this would help if you could do it. Thanks
/ CC @rhtyd @PaulAngus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-738128935
Hi @rhtyd I've just tried simple scenarios - to deploy vm, create template from snapshot and deploy vm from it. If you can help me with scenarios for basic network I could test it.
I found another "problem" but it's not related to the basic zone I guess. When I want to start a VM in the new UI I have option to choose zone,pod,cluster and host which are not related to the VM's zone. In the old UI when I want to start it I have option only to choose configurations from its zone.
Here is a screenshots for what I mean
Old UI the pod,clusters or hosts are listed by the zone id of the VM
From new UI are listed all pods, clusters or hosts without any constrains
Do I have to delete this comment from here and open a new issue (or this is expected behaviour)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728154539
@andrijapanicsb @DaanHoogland the new UI is only GA with 4.15.
Functions may or may not work with pre-GA versions, but they that's not something we should concern ourselves with now.
Also, registering templates in 4.14 with new UI is not related to this Basic Networking testing _issue_. Can I ask that this thread does not continue here. In fact, my preference would be that the whole tangential thread is deleted completely to stop confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-729548535
Hi @slavkap - the first bit of confusion was might fault, I realised that you'd included the browser output after I'd pressed send.
If you had to explicitly set the network values to NULL, then from a defensive programming point of view and a 'let's not confuse the user' point of view; The choice of network, shouldn't be visible to the user when the zone uses basic networking?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-729594546
Hi @PaulAngus I think that network shouldn't be provided for basic networking. Here is the code where it fails when you send the networkid:
```
if (zone.getNetworkType() == NetworkType.Basic) {
if (networkIds != null) {
throw new InvalidParameterValueException("Can't specify network Ids in Basic zone");
} else {
vm = createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, getSecurityGroupIdList(cmd), owner, name, displayName, diskOfferingId,
size , group , cmd.getHypervisor(), cmd.getHttpMethod(), userData , sshKeyPairName , cmd.getIpToNetworkMap(), addrs, displayVm , keyboard , cmd.getAffinityGroupIdList(),
cmd.getDetails(), cmd.getCustomId(), cmd.getDhcpOptionsMap(),
dataDiskTemplateToDiskOfferingMap, userVmOVFProperties);
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-729624300
@PaulAngus @slavkap Created a fix for this https://github.com/apache/cloudstack-primate/pull/864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728757479
@PaulAngus I think that there was a misunderstanding. In m first comment there are two API calls from the new and the old UIs. The first API call is from the new UI (primate) and I have tested with and without mac (first I thought that it's mandatory). And I didn't set rootdisksize because there is only an option to override and I guess that when deploying VM it will get the template size. The second API call is from the old UI and there is rootdisksize provided.
I have tested it now again and at runtime I set the networkids to null and the request didn't fail in the further execution - the VM was deployed correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-739716617
@rhtyd I've tested with the fix and it's work correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus removed a comment on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus removed a comment on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728157738
@slavkap Thank you for your help. Could you test the VM deployment against the master branch please. The new UI will only go GA against 4.15. I suspect that you'll get the same result, but it'll give us a slightly better starting point.
If you wouldn't mind, it would be very helpful if you could use the browser dev tools, to compare the API call made by the old UI to the one sent by the new UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728157738
@slavkap Thank you for your help. Could you test the VM deployment against the master branch please. The new UI will only go GA against 4.15. I suspect that you'll get the same result, but it'll give us a slightly better starting point.
If you wouldn't mind, it would be very helpful if you could use the browser dev tools, to compare the API call made by the old UI to the one sent by the new UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-737766635
@slavkap @weizhouapache @GabrielBrascher @wido - any further update on running tests with basic zone/networking against latest master? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728161383
@slavkap when you deployed the VM in the new UI, did you set the rootdisksize to 8 or has the new UI added it itself?
+ I can only see pain by the UI sending a blank affinitygroupids parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728169120
@davidjumani could you have a look at the extra **_networkid_**, and **_affinitygroupids_**, and _**mac**_ and _**rootdisksize**_ which are being sent when they haven't been set in the UI please. **_networkid_** is breaking VM deployment in basic zones. The others will likely break something at some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-739794313
Thanks @slavkap closing on your remark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-727939427
cc @nvazquez as I think he could advise about that one ^^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-739294168
Tested and merged the PR, pl test and close the PR @andrijapanicsb cc @slavkap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-728175536
@PaulAngus the problem still appears on master. In my previous comment the API calls are copied from dev tools. Also in the new UI I didn't provide rootdisksize because there is only option the override it.
Here are the screenshots from new and old UIs with the API calls:
`http://localhost:5050/client/api/?zoneid=45b4a203-d00e-4e54-b1a8-d7648d2db436&templateid=582131ee-1f50-11eb-ae69-02000a0201ba&serviceofferingid=8b25c596-bdc5-4681-9f3b-6fa3ab998f75&affinitygroupids=&iptonetworklist[0].networkid=dcd06f91-cba0-400d-9e67-644e7419f23c&securitygroupids=9c1ba671-1f51-11eb-ae69-02000a0201ba&command=deployVirtualMachine&response=json`
and old UI
`http://localhost:8080/client/api?command=deployVirtualMachine&response=json&zoneid=45b4a203-d00e-4e54-b1a8-d7648d2db436&templateid=582131ee-1f50-11eb-ae69-02000a0201ba&hypervisor=KVM&rootdisksize=8&serviceofferingid=8b25c596-bdc5-4681-9f3b-6fa3ab998f75&securitygroupids=9c1ba671-1f51-11eb-ae69-02000a0201ba&boottype=BIOS&bootmode=LEGACY&_=1605543657690`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #836: [BASIC NETWORK TESTING]
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #836:
URL: https://github.com/apache/cloudstack-primate/issues/836#issuecomment-727938779
@GabrielBrascher @wido @weizhouapache I tried to test https://github.com/apache/cloudstack/issues/4158 but got stopped in my tracks because of below issue, not sure if it is still a problem but it is for 4.14:
<img width="1427" alt="Screenshot 2020-11-16 at 12 51 54" src="https://user-images.githubusercontent.com/2486961/99250811-8fab0300-280c-11eb-99c2-66b0e304c6fa.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org