[jira] [Created] (HDFS-14509) DN throws InvalidToken due to inequality of password when upgrade NN 2.x to 3.x

["Yuxuan Wang (JIRA)" <ji...@apache.org>]

Yuxuan Wang created HDFS-14509:
----------------------------------

             Summary: DN throws InvalidToken due to inequality of password when upgrade NN 2.x to 3.x
                 Key: HDFS-14509
                 URL: https://issues.apache.org/jira/browse/HDFS-14509
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Yuxuan Wang


According to the doc, if we want to upgrade cluster from 2.x to 3.x, we need upgrade NN first. And there will be a intermediate state that NN is 3.x and DN is 2.x. At that moment, if a client reads (or writes) a block, it will get a block token from NN and then deliver the token to DN who can verify the token. But the verification in the code now is :
{code:title=BlockTokenSecretManager.java|borderStyle=solid}
public void checkAccess(...)
{
    ...
    id.readFields(new DataInputStream(new ByteArrayInputStream(token.getIdentifier())));
    ...
    if (!Arrays.equals(retrievePassword(id), token.getPassword())) {
      throw new InvalidToken("Block token with " + id.toString()
          + " doesn't have the correct token password");
    }
}
{code} 
And {{retrievePassword(id)}} is:
{code} 
public byte[] retrievePassword(BlockTokenIdentifier identifier)
{
    ...
    return createPassword(identifier.getBytes(), key.getKey());
}
{code} 
So, if NN's identifier add new fields, DN will lose the fields and compute wrong password.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org