You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/29 14:26:02 UTC
[GitHub] [shardingsphere] kekerzzZ opened a new pull request #5385: Add 'algorithm.expression' param placeholder handle
kekerzzZ opened a new pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385
Add 'algorithm.expression' param placeholder handle for InlineShardingAlgorithm class.
Fixes #5378.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5385: Add 'algorithm.expression' parameter placeholder handle
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385#issuecomment-621295045
## Pull Request Test Coverage Report for [Build 11355](https://coveralls.io/builds/30434619)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **57.53%**
---
| Totals | [](https://coveralls.io/builds/30434619) |
| :-- | --: |
| Change from base [Build 11349](https://coveralls.io/builds/30426921): | 0.002% |
| Covered Lines: | 11919 |
| Relevant Lines: | 20718 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5385: Add placeholder handle for 'algorithm.expression' parameter of InlineShardingAlgorithm class
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385#issuecomment-621295045
## Pull Request Test Coverage Report for [Build 11361](https://coveralls.io/builds/30452076)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **57.53%**
---
| Totals | [](https://coveralls.io/builds/30452076) |
| :-- | --: |
| Change from base [Build 11349](https://coveralls.io/builds/30426921): | 0.002% |
| Covered Lines: | 11919 |
| Relevant Lines: | 20718 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5385: Add 'algorithm.expression' parameter placeholder handle
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385#issuecomment-621292811
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=h1) Report
> Merging [#5385](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ea4cb057aecfd0d3719d126e05c2702d78cee656&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5385 +/- ##
=========================================
Coverage 54.02% 54.02%
Complexity 412 412
=========================================
Files 1150 1150
Lines 20717 20718 +1
Branches 3754 3754
=========================================
+ Hits 11192 11193 +1
Misses 8812 8812
Partials 713 713
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=tree) | Coverage Ξ | Complexity Ξ | |
|---|---|---|---|
| [...rithm/sharding/inline/InlineShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5385/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvaW5saW5lL0lubGluZVNoYXJkaW5nQWxnb3JpdGhtLmphdmE=) | `58.82% <100.00%> (+2.57%)` | `1.00 <0.00> (ΓΈ)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=footer). Last update [ea4cb05...6b5feab](https://codecov.io/gh/apache/shardingsphere/pull/5385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #5385: Add placeholder handle for 'algorithm.expression' parameter of InlineShardingAlgorithm class
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385#issuecomment-621605692
@kekerzzZ Thanks for another contribution, which is merged into the master branch!
Please enjoy OS journey. π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kekerzzZ commented on pull request #5385: Add 'algorithm.expression' parameter placeholder handle
Posted by GitBox <gi...@apache.org>.
kekerzzZ commented on pull request #5385:
URL: https://github.com/apache/shardingsphere/pull/5385#issuecomment-621577444
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org