You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/20 01:43:11 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1326: Extract Aggregate, Sort, and Join to struct from AggregatePlan

liukun4515 commented on a change in pull request #1326:
URL: https://github.com/apache/arrow-datafusion/pull/1326#discussion_r753617212



##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -154,16 +167,17 @@ pub enum LogicalPlan {
     },
     /// Aggregates its input based on a set of grouping and aggregate
     /// expressions (e.g. SUM).
-    Aggregate {
-        /// The incoming logical plan
-        input: Arc<LogicalPlan>,
-        /// Grouping expressions
-        group_expr: Vec<Expr>,
-        /// Aggregate expressions
-        aggr_expr: Vec<Expr>,
-        /// The schema description of the aggregate output
-        schema: DFSchemaRef,
-    },
+    // Aggregate {

Review comment:
       in the final version, we should remove these useless code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org