You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by xi...@apache.org on 2025/03/26 20:46:17 UTC
(tinkerpop) branch master updated (4f27528cfb -> e1a5eab414)
This is an automated email from the ASF dual-hosted git repository.
xiazcy pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
from 4f27528cfb Merge branch '3.8-dev'
add cfc1957b96 CTR update go version for docker-compose and fix default read/write buffer size for Client and test settings
add 9ab570d2ab Merge branch '3.7-dev' into 3.8-dev
new e1a5eab414 Merge branch '3.8-dev'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGELOG.asciidoc | 1 +
gremlin-go/driver/client.go | 13 ++++++++-----
gremlin-go/driver/connection_test.go | 4 ++--
gremlin-go/driver/driverRemoteConnection.go | 7 ++-----
4 files changed, 13 insertions(+), 12 deletions(-)
(tinkerpop) 01/01: Merge branch '3.8-dev'
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiazcy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit e1a5eab414f5d202c7484a80435ec1dc6bc5ade0
Merge: 4f27528cfb 9ab570d2ab
Author: xiazcy <xi...@gmail.com>
AuthorDate: Wed Mar 26 13:45:55 2025 -0700
Merge branch '3.8-dev'
CHANGELOG.asciidoc | 1 +
gremlin-go/driver/client.go | 13 ++++++++-----
gremlin-go/driver/connection_test.go | 4 ++--
gremlin-go/driver/driverRemoteConnection.go | 7 ++-----
4 files changed, 13 insertions(+), 12 deletions(-)
diff --cc gremlin-go/driver/client.go
index e1a19aa31a,380b556a71..ff625f6dff
--- a/gremlin-go/driver/client.go
+++ b/gremlin-go/driver/client.go
@@@ -27,10 -27,6 +27,16 @@@ import
"golang.org/x/text/language"
)
+const keepAliveIntervalDefault = 5 * time.Second
+const writeDeadlineDefault = 3 * time.Second
+const connectionTimeoutDefault = 5 * time.Second
+
++// ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. The default is 1MB.
++// If a buffer size is set zero, then the transporter default size is used. The I/O buffer
++// sizes do not limit the size of the messages that can be sent or received.
++const readBufferSizeDefault = 1048576
++const writeBufferSizeDefault = 1048576
++
// ClientSettings is used to modify a Client's settings on initialization.
type ClientSettings struct {
TraversalSource string
@@@ -75,13 -79,12 +81,10 @@@ func NewClient(url string, configuratio
ConnectionTimeout: connectionTimeoutDefault,
EnableCompression: false,
EnableUserAgentOnConnect: true,
- // ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. If a buffer
- // size is zero, then a useful default size is used. The I/O buffer sizes
- // do not limit the size of the messages that can be sent or received.
- ReadBufferSize: 0,
- WriteBufferSize: 0,
+ ReadBufferSize: readBufferSizeDefault,
+ WriteBufferSize: writeBufferSizeDefault,
- NewConnectionThreshold: defaultNewConnectionThreshold,
MaximumConcurrentConnections: runtime.NumCPU(),
- InitialConcurrentConnections: defaultInitialConcurrentConnections,
}
for _, configuration := range configurations {
configuration(settings)
diff --cc gremlin-go/driver/driverRemoteConnection.go
index d97c7bb95a,a0f155f4c4..86de97784a
--- a/gremlin-go/driver/driverRemoteConnection.go
+++ b/gremlin-go/driver/driverRemoteConnection.go
@@@ -77,13 -85,12 +77,10 @@@ func NewDriverRemoteConnection
ConnectionTimeout: connectionTimeoutDefault,
EnableCompression: false,
EnableUserAgentOnConnect: true,
- // ReadBufferSize and WriteBufferSize specify I/O buffer sizes in bytes. The default is 1048576.
- // If a buffer size is set zero, then the default size is used. The I/O buffer
- // sizes do not limit the size of the messages that can be sent or received.
- ReadBufferSize: 1048576,
- WriteBufferSize: 1048576,
+ ReadBufferSize: readBufferSizeDefault,
+ WriteBufferSize: writeBufferSizeDefault,
- NewConnectionThreshold: defaultNewConnectionThreshold,
MaximumConcurrentConnections: runtime.NumCPU(),
- InitialConcurrentConnections: defaultInitialConcurrentConnections,
}
for _, configuration := range configurations {
configuration(settings)