[GitHub] [pulsar] merlimat commented on pull request #11764: Fixed race condition on multi-topic consumer

[GitBox <gi...@apache.org>]

merlimat commented on pull request #11764:
URL: https://github.com/apache/pulsar/pull/11764#issuecomment-905229853


   > LGTM
   > 
   > pendingReceives also seems to have a race condition, two threads will operate pendingReceives :
   > 
   > receiveMessageFromConsumer is executed by client.getInternalExecutorService().execute
   > internalReceiveAsync is executed by the user's thread
   > 
   
   I think the usage on `pendingReceives` is correct even if used by different threads. Can you describe the particular race condition and the effects that it would have?
   
   > It is better to put them all in pinnedExecutor, I am working on it. And it can solve the above scenario at the same time
   
   My concern there is that if you have a multi-topic consumer pulling from many topics, we shouldn't be bottlenecked by 1 single thread. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org