You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/10 08:04:33 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
zhengruifeng opened a new pull request, #38186:
URL: https://github.com/apache/spark/pull/38186
### What changes were proposed in this pull request?
Add `mypy-protobuf` to dev/requirements
### Why are the changes needed?
`connector/connect/dev/generate_protos.sh` requires this package:
```
DEBUG /buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins {"duration": "14.25µs", "http.path": "/buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins", "http.url": "https://api.buf.build/buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins", "http.host": "api.buf.build", "http.method": "POST", "http.user_agent": "connect-go/0.4.0-dev (go1.19.2)"}
DEBUG command {"duration": "9.238333ms"}
Failure: plugin mypy: could not find protoc plugin for name mypy
```
### Does this PR introduce _any_ user-facing change?
No, only for contributors
### How was this patch tested?
manually check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38186:
URL: https://github.com/apache/spark/pull/38186#issuecomment-1273837223
Late +1!
I found this in my branch then I found it's fixed so fast!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38186:
URL: https://github.com/apache/spark/pull/38186#issuecomment-1273002841
@Yikun, this PR doesn't require the CI to pass.
Wanna try to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38186:
URL: https://github.com/apache/spark/pull/38186#issuecomment-1273038350
thanks @Yikun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38186:
URL: https://github.com/apache/spark/pull/38186#issuecomment-1273039908
@zhengruifeng @HyukjinKwon Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun closed pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #38186: [SPARK-40725][INFRA] Add `mypy-protobuf` to dev/requirements
URL: https://github.com/apache/spark/pull/38186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org