You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/28 16:57:42 UTC
[GitHub] [tvm] mbrookhart opened a new pull request #7362: Type Relation Fixes
mbrookhart opened a new pull request #7362:
URL: https://github.com/apache/tvm/pull/7362
I ran into a couple of bugs in type relations while debugging a model. The first is an issue with dynamic full not checking one of it's inputs for an incomplete type. The second is adding better error handling to Broadcast Type Relations.
cc @jwfromm @electriclilies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on pull request #7362: [Relay] Type Relation Fixes
Posted by GitBox <gi...@apache.org>.
electriclilies commented on pull request #7362:
URL: https://github.com/apache/tvm/pull/7362#issuecomment-769411425
LGTM, I just noticed that the dynamic FullRel also doesn't return false if fill_shape is null. Might be good to fix that in this PR too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies edited a comment on pull request #7362: [Relay] Type Relation Fixes
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on pull request #7362:
URL: https://github.com/apache/tvm/pull/7362#issuecomment-769411425
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7362: [Relay] Type Relation Fixes
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7362:
URL: https://github.com/apache/tvm/pull/7362#issuecomment-769430372
Thanks @jwfromm @electriclilies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #7362: [Relay] Type Relation Fixes
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #7362:
URL: https://github.com/apache/tvm/pull/7362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org