You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/01 08:18:51 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #6467: refactor(grpc-transcode): new way to handle pb file

spacewander commented on a change in pull request #6467:
URL: https://github.com/apache/apisix/pull/6467#discussion_r816539196



##########
File path: apisix/plugins/grpc-transcode/proto.lua
##########
@@ -77,20 +77,22 @@ local function compile_proto_bin(content)
         return nil
     end
 
+    local files = pb.decode("google.protobuf.FileDescriptorSet", content).file

Review comment:
       The test cases are https://github.com/apache/apisix/blob/beff2df3311d86260db75315af1974e8d7326217/t/plugin/grpc-transcode2.t#L236 and below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org