You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/04/20 20:17:18 UTC
[GitHub] [superset] rusackas opened a new pull request, #23759: chore(actions): Fix for Chromatic action using actions/checkout@v3
rusackas opened a new pull request, #23759:
URL: https://github.com/apache/superset/pull/23759
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The Chromatic action is broken on `master` CI builds. The error indicates that it's due to a recent PR where the checkout action was bumped from v1 to v3. The error leads to [this documentation](https://www.chromatic.com/docs/github-actions#support-for-codeactionscheckoutv2code-and-above), so this PR makes an update accordingly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Merge (if CI passes here) and monitor CI on `master`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23759: chore(actions): Fix for Chromatic action using actions/checkout@v3
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23759:
URL: https://github.com/apache/superset/pull/23759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23759: chore(actions): Fix for Chromatic action using actions/checkout@v3
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23759:
URL: https://github.com/apache/superset/pull/23759#issuecomment-1516901228
## [Codecov](https://codecov.io/gh/apache/superset/pull/23759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23759](https://codecov.io/gh/apache/superset/pull/23759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05b5900) into [master](https://codecov.io/gh/apache/superset/commit/818a1d482bb22f2a243b874ed909a1be55e76282?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (818a1d4) will **decrease** coverage by `11.42%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23759 +/- ##
===========================================
- Coverage 68.09% 56.68% -11.42%
===========================================
Files 1922 1922
Lines 74075 74075
Branches 8100 8100
===========================================
- Hits 50445 41993 -8452
- Misses 21553 30005 +8452
Partials 2077 2077
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.10% <ø> (ø)` | |
| python | `59.42% <ø> (-23.73%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 302 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23759/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org