[GitHub] andrzej-kaczmarek commented on a change in pull request #58: call ble_gatts_chr_updated() on battery level change

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #58: call ble_gatts_chr_updated() on battery level change
URL: https://github.com/apache/mynewt-nimble/pull/58#discussion_r183638509
 
 

 ##########
 File path: nimble/host/services/bas/src/ble_svc_bas.c
 ##########
 @@ -118,17 +118,15 @@ ble_svc_bas_on_gap_connect(uint16_t conn_handle)
  */
 int
 ble_svc_bas_battery_level_set(uint8_t level) {
-    int rc = 0;
     if (level > 100)
 	level = 100;
     if (ble_svc_bas_battery_level != level) {
 	ble_svc_bas_battery_level = level;
 #if MYNEWT_VAL(BLE_SVC_BAS_BATTERY_LEVEL_NOTIFY_ENABLE) > 0
-	rc = ble_gattc_notify(ble_svc_bas_conn_handle,
-			      ble_svc_bas_battery_handle);
+        ble_gatts_chr_updated(ble_svc_bas_battery_handle);
 
 Review comment:
   so if `ble_svc_bas_conn_handle` is not needed you should also remove other code which references it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services