You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Remilito <gi...@git.apache.org> on 2017/03/17 15:59:08 UTC
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
GitHub user Remilito opened a pull request:
https://github.com/apache/zeppelin/pull/2151
[ZEPPELIN-465] Be able to run paragraph and the following ones
### What is this PR for?
Allow to run a paragraph **and** the ones following. This is useful for instance if you are generating a dataset in a paragraph and then have others subsequent paragraphs relying on this dataset.
In a nutshell this PR contains:
* UI: added a button to paragraph
* REST: added an boolean option to runparagraph (sync & async)
* updated rest doc
* z-engine: added relevant function to Note
* also refacto some duplicated code here and there.
### What type of PR is it?
Feature
### Todos
* [ ] - Once committers agree on the visual impact (currently a new button on paragraph commands but can be discussed), update relevant documentation.
### What is the Jira issue?
[ZEPPELIN-465](https://issues.apache.org/jira/browse/ZEPPELIN-465)
### How should this be tested?
* UI: click on the button and verify subsequent paragraphs are also run, and precedent ones.
* REST: post request to /api/notebook/[job|run]/$noteId/$paragraphId?subsequent=true
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2151
----
commit 9ba0d38b93a5bf27eaceeeedb579af7256ac0d18
Author: Remilito <re...@gmail.com>
Date: 2017-03-16T14:10:40Z
[ZEPPELIN-465] Be able to run paragraph and the following ones
* UI: added a button to paragraph
* REST: added an boolean option to runparagraph (sync & async)
* updated rest doc
* z-engine: added relevant function to Note
* also refacto some duplicated code here and there.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2151
@AhyoungRyu : updated (and now building and passing tests :sweat_smile: ).
@jongyoul : I am not sure to fully understand what you mean. If you are talking "UI" IMO the need to run or not a sequence of paragraphs depends mostly on the paragraphs' contents (i.e. generation of a dataset used by following paragraphs), so I find it more convenient to trigger this directly in the paragraph view rather than putting it in the job view. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2151
@Remilito Tested and it works as expected.
Regarding docs, how about adding new section for this feature instead of `subsequent parameter (optional)` as a subsection under "Run a paragraph synchronously" & "Run a paragraph asynchronously" ? I saw many ppl have wanted this feature, so it'll be better to create new section for it. Below each "Run a paragraph synchronously" & "Run a paragraph asynchronously" section would be good place i think. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] [On-hold] Be able to run paragraph and ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2151
I think JobSever is more proper location to handle the job status and relationship. How do you think of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito closed the pull request at:
https://github.com/apache/zeppelin/pull/2151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2151
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2151
@AhyoungRyu sorry for the late answer, I have updated the doc accordingly to your advice, and changed the wording of the UI command. It is now "Run with successors", but if a native English speaker has a better wording, any help is appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2151
Hi,@Remilito. I think now you needed a doing rebase.
Could you rebase it, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
Posted by Remilito <gi...@git.apache.org>.
GitHub user Remilito reopened a pull request:
https://github.com/apache/zeppelin/pull/2151
[ZEPPELIN-465] Be able to run paragraph and the following ones
### What is this PR for?
Allow to run a paragraph **and** the ones following. This is useful for instance if you are generating a dataset in a paragraph and then have others subsequent paragraphs relying on this dataset.
In a nutshell this PR contains:
* UI: added a command in paragraph dropdown menu
* REST: added an boolean option to runparagraph (sync & async)
* updated rest doc
* z-engine: added relevant function to Note
* also refacto some duplicated code here and there.
### What type of PR is it?
Feature
### Todos
* [ ] - Once committers agree on the visual impact, update relevant documentation.
### What is the Jira issue?
[ZEPPELIN-465](https://issues.apache.org/jira/browse/ZEPPELIN-465)
### How should this be tested?
* UI: click on the "run and next ones" in the dropdown menu and verify subsequent paragraphs are also run, and not precedent ones.
* REST: post request to /api/notebook/[job|run]/$noteId/$paragraphId?subsequent=true
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2151
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] [On-hold] Be able to run paragraph and ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2151
@Remilito Thanks for the useful feature.
I think it'll be better to display only essential buttons in the paragraph. How about placing it under paragraph control dropdown menu instead? I mean in here
<img width="295" alt="screen shot 2017-03-20 at 1 59 43 pm" src="https://cloud.githubusercontent.com/assets/10060731/24089082/81cb1b40-0d75-11e7-91f3-e9c8ebd3f11c.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2151
---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2151
Here's one related PR #2195 which do it in `ZeppelinContext`, I hope we can merge these 2 tickets to use the same approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---