You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/16 14:50:56 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

lhotari opened a new pull request #10247:
URL: https://github.com/apache/pulsar/pull/10247


   ### Motivation
   
   While investigating the issue about geo replication, #10054 , I came across some issues with handling of some deserialized replicated subscriptions related messages. LightProto reuses thread local instances and therefore a copy must be made before sharing with other threads.
   
   ### Modifications
   
   - Make a copy of `ReplicatedSubscriptionsSnapshot` before adding it to `ReplicatedSubscriptionSnapshotCache`
   - Make a copy of `MarkersMessageIdData` before adding it to `responses` map in `ReplicatedSubscriptionsSnapshotBuilder`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

Posted by GitBox <gi...@apache.org>.

merlimat merged pull request #10247:
URL: https://github.com/apache/pulsar/pull/10247


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

Posted by GitBox <gi...@apache.org>.

lhotari commented on pull request #10247:
URL: https://github.com/apache/pulsar/pull/10247#issuecomment-821236551


   @merlimat Please review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org