You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 01:06:07 UTC
[GitHub] [flink] chendonglin521 opened a new pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
chendonglin521 opened a new pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848
## What is the purpose of the change
Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
Given that the failover strategy class names are transparent to users
## Brief change log
- *Rename Subclasses of FailoverStrategy *
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-574626118
I am fine with the name changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366142860
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGAbortPendingCheckpointsTest.java
##########
@@ -59,7 +59,7 @@
/**
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG}.
*/
-public class AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest extends TestLogger {
+public class AdaptedRestartPipelinedRegionFailoverStrategyNGAbortPendingCheckpointsTest extends TestLogger {
Review comment:
We should not do this since this PR does not rename AdaptedRestartPipelinedRegionStrategyNG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366143882
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
##########
@@ -77,9 +77,9 @@
@Before
public void createHDFS() throws IOException {
if (failoverStrategy.equals(FailoverStrategy.RestartPipelinedRegionStrategy)) {
- // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionStrategy,
- // for this ContinuousFileProcessingCheckpointITCase, using RestartPipelinedRegionStrategy would result in endless running.
- throw new AssumptionViolatedException("ignored ContinuousFileProcessingCheckpointITCase when using RestartPipelinedRegionStrategy");
+ // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionFailoverStrategy,
Review comment:
This is actually not `flip. RestartPipelinedRegionStrategy ` but `StreamFaultToleranceTestBase#FailoverStrategy`.
I think we need to rename the enums in it as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573950191
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a3f83df73af74cf8509f084e860ab88e63129ac8 (Tue Jan 14 01:09:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] chendonglin521 commented on a change in pull request
#10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366637303
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
##########
@@ -77,9 +77,9 @@
@Before
public void createHDFS() throws IOException {
if (failoverStrategy.equals(FailoverStrategy.RestartPipelinedRegionStrategy)) {
- // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionStrategy,
- // for this ContinuousFileProcessingCheckpointITCase, using RestartPipelinedRegionStrategy would result in endless running.
- throw new AssumptionViolatedException("ignored ContinuousFileProcessingCheckpointITCase when using RestartPipelinedRegionStrategy");
+ // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionFailoverStrategy,
Review comment:
@zhuzhurk Hi zhuzhu, Appreciation of your kind guidance , and I've updated it according to your comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk closed pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-574477458
Thanks for addressing the comments @chendonglin521 .
The change looks good to me now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366143207
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGConcurrentFailoverTest.java
##########
@@ -51,7 +51,7 @@
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG} failover handling when concurrent failovers happen.
* There can be local+local and local+global concurrent failovers.
*/
-public class AdaptedRestartPipelinedRegionStrategyNGConcurrentFailoverTest extends TestLogger {
+public class AdaptedRestartPipelinedRegionFailoverStrategyNGConcurrentFailoverTest extends TestLogger {
Review comment:
It's related to a legacy failover strategy `AdaptedRestartPipelinedRegionStrategyNG` so do not rename it in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144458012 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
* a276721f15511989b1d714eaf3b9da363c43d996 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144458012) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] chendonglin521 commented on a change in pull request
#10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366633444
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
##########
@@ -77,9 +77,9 @@
@Before
public void createHDFS() throws IOException {
if (failoverStrategy.equals(FailoverStrategy.RestartPipelinedRegionStrategy)) {
- // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionStrategy,
- // for this ContinuousFileProcessingCheckpointITCase, using RestartPipelinedRegionStrategy would result in endless running.
- throw new AssumptionViolatedException("ignored ContinuousFileProcessingCheckpointITCase when using RestartPipelinedRegionStrategy");
+ // TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionFailoverStrategy,
Review comment:
I can't agree with you more. I will rename the enums
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
* a276721f15511989b1d714eaf3b9da363c43d996 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144458012 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
* a276721f15511989b1d714eaf3b9da363c43d996 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144458012) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-573958003
<!--
Meta data
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144251297 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:a3f83df73af74cf8509f084e860ab88e63129ac8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310 TriggerType:PUSH TriggerID:a3f83df73af74cf8509f084e860ab88e63129ac8
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144257490 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:c2f939165d6d4aa4907591f57b1a14c9578c2122 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315 TriggerType:PUSH TriggerID:c2f939165d6d4aa4907591f57b1a14c9578c2122
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144435003 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:697bdb396a18cc88f14f313cb8845d94cfdea3aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347 TriggerType:PUSH TriggerID:697bdb396a18cc88f14f313cb8845d94cfdea3aa
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144458012 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
Hash:a276721f15511989b1d714eaf3b9da363c43d996 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356 TriggerType:PUSH TriggerID:a276721f15511989b1d714eaf3b9da363c43d996
-->
## CI report:
* a3f83df73af74cf8509f084e860ab88e63129ac8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144251297) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4310)
* c2f939165d6d4aa4907591f57b1a14c9578c2122 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144257490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4315)
* 697bdb396a18cc88f14f313cb8845d94cfdea3aa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144435003) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4347)
* a276721f15511989b1d714eaf3b9da363c43d996 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144458012) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] chendonglin521 commented on a change in pull request
#10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366632923
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest.java
##########
@@ -63,7 +63,7 @@
/**
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG} failover handling.
*/
-public class AdaptedRestartPipelinedRegionStrategyNGFailoverTest extends TestLogger {
+public class AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest extends TestLogger {
Review comment:
OK, I check carefully and modify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#issuecomment-574629419
Thanks for the feedback @GJL .
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #10848:
[FLINK-15307][failover]Rename Subclasses of FailoverStrategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #10848: [FLINK-15307][failover]Rename Subclasses of FailoverStrategy
URL: https://github.com/apache/flink/pull/10848#discussion_r366143327
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest.java
##########
@@ -63,7 +63,7 @@
/**
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG} failover handling.
*/
-public class AdaptedRestartPipelinedRegionStrategyNGFailoverTest extends TestLogger {
+public class AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest extends TestLogger {
Review comment:
This change is not needed. See my other 2 comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services