You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Sunstreaker (via GitHub)" <gi...@apache.org> on 2023/04/13 07:14:58 UTC
[GitHub] [eventmesh] Sunstreaker opened a new pull request, #3716: #3407
Sunstreaker opened a new pull request, #3716:
URL: https://github.com/apache/eventmesh/pull/3716
Make this anonymous inner class a lambda[
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3407
### Motivation
*Enhancement.*
### Modifications
*Code refactor from anonymous inner class a lambda[SendSyncMessageProcessor].*
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why? - Code refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3716: [ISSUE #3407] Make this anonymous inner class a lambda[SendSyncMessageProcessor]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Sunstreaker commented on pull request #3716: #3407
Posted by "Sunstreaker (via GitHub)" <gi...@apache.org>.
Sunstreaker commented on PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716#issuecomment-1506470409
@Alonexc Please review and help me in merging the PR !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3716: #3407
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716#issuecomment-1523091944
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3716](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55e692c) into [master](https://codecov.io/gh/apache/eventmesh/commit/5a49a7308821e0957bbd98841c7549a03fce6b3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a49a73) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 55e692c differs from pull request most recent head 09f7364. Consider uploading reports for the commit 09f7364 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3716 +/- ##
============================================
- Coverage 13.77% 13.74% -0.03%
+ Complexity 1292 1291 -1
============================================
Files 571 571
Lines 29236 29227 -9
Branches 2884 2870 -14
============================================
- Hits 4026 4018 -8
+ Misses 24837 24836 -1
Partials 373 373
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/eventmesh/common/config/ConfigService.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | `44.44% <0.00%> (ø)` | |
| [...h/registry/nacos/service/NacosRegistryService.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktbmFjb3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9yZWdpc3RyeS9uYWNvcy9zZXJ2aWNlL05hY29zUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `36.56% <0.00%> (ø)` | |
| [...tocol/http/processor/SendSyncMessageProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU2VuZFN5bmNNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../protocol/http/processor/UnSubscribeProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvVW5TdWJzY3JpYmVQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ime/core/protocol/tcp/client/task/GoodbyeTask.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0dvb2RieWVUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../java/org/apache/eventmesh/runtime/util/Utils.java](https://codecov.io/gh/apache/eventmesh/pull/3716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3716/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3716: #3407
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716#issuecomment-1508082264
Of course, please wait, I don't have permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mroccyen commented on pull request #3716: #3407
Posted by "mroccyen (via GitHub)" <gi...@apache.org>.
mroccyen commented on PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716#issuecomment-1523058037
Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Sunstreaker commented on pull request #3716: #3407
Posted by "Sunstreaker (via GitHub)" <gi...@apache.org>.
Sunstreaker commented on PR #3716:
URL: https://github.com/apache/eventmesh/pull/3716#issuecomment-1507912711
@Alonexc possible to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org