You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Bob Morley <rm...@emforium.com> on 2009/10/26 20:59:41 UTC
Java warnings in Eclipse
One of the frequent complaints we have in our office is the huge number of
java problems that are reported on the Ofbiz source code in Eclipse. A few
people have asked me about the best approach to fixing them and getting them
back into Ofbiz (in fact someone just said to me "these are driving me crazy
I want to fix them all").
So the question is a) if we were to do this would be be able to get it
contributed into the product and b) what is the best way to contribute these
back so that we are not too granular, but we do not provide a huge set of
files to commit.
We have someone chomping on the bit to fix up all of these things; so if we
can get consensus we can get 'er done!
Thoughts?
--
View this message in context: http://n4.nabble.com/Java-warnings-in-Eclipse-tp277061p277061.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Java warnings in Eclipse
Posted by David E Jones <de...@me.com>.
I don't think any special handling is needed for these. The normal
create a patch and attach it to a Jira issue should be fine.
And yes, I agree that putting them in larger batches (ie patch files
with a larger number of changes) would be good, and is typical for
things like this (like i18n stuff for example with lots of label
changes in a single patch).
-David
On Oct 26, 2009, at 1:59 PM, Bob Morley wrote:
>
> One of the frequent complaints we have in our office is the huge
> number of
> java problems that are reported on the Ofbiz source code in
> Eclipse. A few
> people have asked me about the best approach to fixing them and
> getting them
> back into Ofbiz (in fact someone just said to me "these are driving
> me crazy
> I want to fix them all").
>
> So the question is a) if we were to do this would be be able to get it
> contributed into the product and b) what is the best way to
> contribute these
> back so that we are not too granular, but we do not provide a huge
> set of
> files to commit.
>
> We have someone chomping on the bit to fix up all of these things;
> so if we
> can get consensus we can get 'er done!
>
> Thoughts?
> --
> View this message in context: http://n4.nabble.com/Java-warnings-in-Eclipse-tp277061p277061.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Java warnings in Eclipse
Posted by Adrian Crum <ad...@hlmksw.com>.
That's great - thanks!
-Adrian
Bob Morley wrote:
> Hey Adrian,
>
> I have created a parent JIRA ticket
> (https://issues.apache.org/jira/browse/OFBIZ-3100) and started to create
> sub-tasks for each component in the system. We will have folks here tackle
> them piece-meal until we get all of the sub-tasks resolved. We will be sure
> to sync to the trunk before working on them so that they will be as close to
> possible when you get time to review. Naturally this process may take a bit
> of time.
>
> Let me know if you want any changes as we move forward.
>
>
> Adrian Crum wrote:
>> Cool. I'll help review and commit them. Just make sure the patches
>> contain only the compiler warning fixes and nothing else - that will
>> make the review easier.
>>
>> -Adrian
>>
>> Bob Morley wrote:
>>> Sounds good -- I will create a JIRA per component and we can break them
>>> into
>>> several files for some of the bigger components.
>>>
>>>
>>> Adrian Crum wrote:
>>>> Maybe tackle them one component at a time. Just create a Jira issue for
>>>> each one.
>>>>
>>>> -Adrian
>>>>
>>>> Bob Morley wrote:
>>>>> One of the frequent complaints we have in our office is the huge number
>>>>> of
>>>>> java problems that are reported on the Ofbiz source code in Eclipse. A
>>>>> few
>>>>> people have asked me about the best approach to fixing them and getting
>>>>> them
>>>>> back into Ofbiz (in fact someone just said to me "these are driving me
>>>>> crazy
>>>>> I want to fix them all").
>>>>>
>>>>> So the question is a) if we were to do this would be be able to get it
>>>>> contributed into the product and b) what is the best way to contribute
>>>>> these
>>>>> back so that we are not too granular, but we do not provide a huge set
>>>>> of
>>>>> files to commit.
>>>>>
>>>>> We have someone chomping on the bit to fix up all of these things; so
>>>>> if
>>>>> we
>>>>> can get consensus we can get 'er done!
>>>>>
>>>>> Thoughts?
>>
>
Re: Java warnings in Eclipse
Posted by Bob Morley <rm...@emforium.com>.
Hey Adrian,
I have created a parent JIRA ticket
(https://issues.apache.org/jira/browse/OFBIZ-3100) and started to create
sub-tasks for each component in the system. We will have folks here tackle
them piece-meal until we get all of the sub-tasks resolved. We will be sure
to sync to the trunk before working on them so that they will be as close to
possible when you get time to review. Naturally this process may take a bit
of time.
Let me know if you want any changes as we move forward.
Adrian Crum wrote:
>
> Cool. I'll help review and commit them. Just make sure the patches
> contain only the compiler warning fixes and nothing else - that will
> make the review easier.
>
> -Adrian
>
> Bob Morley wrote:
>> Sounds good -- I will create a JIRA per component and we can break them
>> into
>> several files for some of the bigger components.
>>
>>
>> Adrian Crum wrote:
>>> Maybe tackle them one component at a time. Just create a Jira issue for
>>> each one.
>>>
>>> -Adrian
>>>
>>> Bob Morley wrote:
>>>> One of the frequent complaints we have in our office is the huge number
>>>> of
>>>> java problems that are reported on the Ofbiz source code in Eclipse. A
>>>> few
>>>> people have asked me about the best approach to fixing them and getting
>>>> them
>>>> back into Ofbiz (in fact someone just said to me "these are driving me
>>>> crazy
>>>> I want to fix them all").
>>>>
>>>> So the question is a) if we were to do this would be be able to get it
>>>> contributed into the product and b) what is the best way to contribute
>>>> these
>>>> back so that we are not too granular, but we do not provide a huge set
>>>> of
>>>> files to commit.
>>>>
>>>> We have someone chomping on the bit to fix up all of these things; so
>>>> if
>>>> we
>>>> can get consensus we can get 'er done!
>>>>
>>>> Thoughts?
>>>
>>
>
>
--
View this message in context: http://n4.nabble.com/Java-warnings-in-Eclipse-tp277061p277522.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Java warnings in Eclipse
Posted by Adrian Crum <ad...@hlmksw.com>.
Cool. I'll help review and commit them. Just make sure the patches
contain only the compiler warning fixes and nothing else - that will
make the review easier.
-Adrian
Bob Morley wrote:
> Sounds good -- I will create a JIRA per component and we can break them into
> several files for some of the bigger components.
>
>
> Adrian Crum wrote:
>> Maybe tackle them one component at a time. Just create a Jira issue for
>> each one.
>>
>> -Adrian
>>
>> Bob Morley wrote:
>>> One of the frequent complaints we have in our office is the huge number
>>> of
>>> java problems that are reported on the Ofbiz source code in Eclipse. A
>>> few
>>> people have asked me about the best approach to fixing them and getting
>>> them
>>> back into Ofbiz (in fact someone just said to me "these are driving me
>>> crazy
>>> I want to fix them all").
>>>
>>> So the question is a) if we were to do this would be be able to get it
>>> contributed into the product and b) what is the best way to contribute
>>> these
>>> back so that we are not too granular, but we do not provide a huge set of
>>> files to commit.
>>>
>>> We have someone chomping on the bit to fix up all of these things; so if
>>> we
>>> can get consensus we can get 'er done!
>>>
>>> Thoughts?
>>
>
Re: Java warnings in Eclipse
Posted by Bob Morley <rm...@emforium.com>.
Sounds good -- I will create a JIRA per component and we can break them into
several files for some of the bigger components.
Adrian Crum wrote:
>
> Maybe tackle them one component at a time. Just create a Jira issue for
> each one.
>
> -Adrian
>
> Bob Morley wrote:
>> One of the frequent complaints we have in our office is the huge number
>> of
>> java problems that are reported on the Ofbiz source code in Eclipse. A
>> few
>> people have asked me about the best approach to fixing them and getting
>> them
>> back into Ofbiz (in fact someone just said to me "these are driving me
>> crazy
>> I want to fix them all").
>>
>> So the question is a) if we were to do this would be be able to get it
>> contributed into the product and b) what is the best way to contribute
>> these
>> back so that we are not too granular, but we do not provide a huge set of
>> files to commit.
>>
>> We have someone chomping on the bit to fix up all of these things; so if
>> we
>> can get consensus we can get 'er done!
>>
>> Thoughts?
>
>
--
View this message in context: http://n4.nabble.com/Java-warnings-in-Eclipse-tp277061p277067.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Java warnings in Eclipse
Posted by Adrian Crum <ad...@hlmksw.com>.
Maybe tackle them one component at a time. Just create a Jira issue for
each one.
-Adrian
Bob Morley wrote:
> One of the frequent complaints we have in our office is the huge number of
> java problems that are reported on the Ofbiz source code in Eclipse. A few
> people have asked me about the best approach to fixing them and getting them
> back into Ofbiz (in fact someone just said to me "these are driving me crazy
> I want to fix them all").
>
> So the question is a) if we were to do this would be be able to get it
> contributed into the product and b) what is the best way to contribute these
> back so that we are not too granular, but we do not provide a huge set of
> files to commit.
>
> We have someone chomping on the bit to fix up all of these things; so if we
> can get consensus we can get 'er done!
>
> Thoughts?