You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/09 19:41:15 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #2830: Driver-specific spinlock for cxd56_serial.c

gustavonihei commented on a change in pull request #2830:
URL: https://github.com/apache/incubator-nuttx/pull/2830#discussion_r573184352



##########
File path: include/nuttx/spinlock.h
##########
@@ -30,7 +30,11 @@
 #include <sys/types.h>
 #include <stdint.h>
 
-#ifdef CONFIG_SPINLOCK
+#ifndef CONFIG_SPINLOCK

Review comment:
       I'm trying to understand the outcome of this change when `CONFIG_SPINLOCK` is not defined.
   From what I understood, `&priv->lock` should always evaluate to `NULL` when `CONFIG_SPINLOCK` is not defined.
   I've tried to isolate this behavior, but I couldn't achieve the same result.
   
   https://godbolt.org/z/467afd
   
   Did I do something wrong in my test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org