You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/02 19:58:25 UTC
[GitHub] [trafficserver] duke8253 opened a new pull request #7673: Change debug tags and make sure sni is printed on certain logs
duke8253 opened a new pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812727843
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812712074
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#discussion_r606687343
##########
File path: iocore/net/SSLClientUtils.cc
##########
@@ -82,6 +82,11 @@ verify_callback(int signature_ok, X509_STORE_CTX *ctx)
} else {
sni_name = buff;
}
+ if (is_debug_tag_set("ssl_verify")) {
+ Debug("ssl_verify", "Core server certificate verification failed for (%s). Action=%s Error=%s server=%s(%s) depth=%d",
+ sni_name, enforce_mode ? "Terminate" : "Continue", X509_verify_cert_error_string(err),
+ netvc->options.ssl_servername.get(), buff, depth);
+ }
Review comment:
Are you wrapping these in the conditional because the computation of the parts of the message are expensive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-815051132
Oh, I didn't catch that the Warning messages were going away. I thought you were just adding Debug messages in parallel so in the more detailed case all would show up in traffic.out.
I know that our ops guys rely on the certificate verification messages always showing up. They use that to check when to yell at origins for having bad certs. They don't run with debug enabled enough for that to be equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812721359
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich edited a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-815051132
Oh, I didn't catch that the Warning messages were going away. I thought you were just adding Debug messages in parallel so in the more detailed case all would show up in traffic.out.
I know that @djcarlin relies on the certificate verification messages always showing up. He uses that to check when to yell at origins for having bad certs. They don't run with debug enabled enough for that to be equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812721359
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812718352
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich edited a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-815051132
Oh, I didn't catch that the Warning messages were going away. I thought you were just adding Debug messages in parallel so in the more detailed case all would show up in traffic.out.
I know that @djcarlin relies on the certificate verification messages always showing up. They use that to check when to yell at origins for having bad certs. They don't run with debug enabled enough for that to be equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812712074
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812718925
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
duke8253 commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-868799274
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812718925
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-816831338
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 merged pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
duke8253 merged pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich edited a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-815051132
Oh, I didn't catch that the Warning messages were going away. I thought you were just adding Debug messages in parallel so in the more detailed case all would show up in traffic.out.
I know that @djcarlin relies on the certificate verification messages always showing up. He uses that to check when to yell at origins for having bad certs. He doesn't run with debug enabled enough for that to be equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] duke8253 commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
duke8253 commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-814265128
> Changing tag is probably ok, but changing `Warning` to `Debug` may be not. Warnings are printed regardless of `diags.debug.enabled` and `diags.debug.tags`, and those would be disappeared on prod. If those warnings are not really important on prod then I'm ok with making them debug log, but users watching the warnings would be surprised. We might want to mark this incompatible. I didn't check how `SSLError` works but I have the same concern on it as well.
I thought about that too, but the message logged in Diags also seems reasonable to be in debug logs as well. We will have our ops team test this out for a few days and see what they prefers, I'll make adjustments according to their comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-816831338
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-868699207
@randall is going to review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812718352
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812759700
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812727843
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812720982
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7673: Change debug tags and make sure sni is printed on certain logs
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#issuecomment-812720982
[approve ci].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org