You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/02/09 03:20:10 UTC
[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #854: [SCB-2094]Bson parsing specification for persistent data
robotLJW opened a new pull request #854:
URL: https://github.com/apache/servicecomb-service-center/pull/854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #854: [SCB-2094]Bson parsing specification for persistent data
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #854:
URL: https://github.com/apache/servicecomb-service-center/pull/854#discussion_r572615270
##########
File path: pkg/rbacframe/account.go
##########
@@ -31,8 +31,8 @@ type Account struct {
Name string `json:"name,omitempty"`
Password string `json:"password,omitempty"`
Roles []string `json:"roles,omitempty"`
- TokenExpirationTime string `json:"tokenExpirationTime,omitempty"`
- CurrentPassword string `json:"currentPassword,omitempty"`
+ TokenExpirationTime string `json:"tokenExpirationTime,omitempty" bson:"token_expiration_time"`
Review comment:
这个结构体应该切换到cari里的结构体
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #854: [SCB-2094]Bson parsing specification for persistent data
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #854:
URL: https://github.com/apache/servicecomb-service-center/pull/854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #854: [SCB-2094]Bson parsing specification for persistent data
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #854:
URL: https://github.com/apache/servicecomb-service-center/pull/854#discussion_r572615270
##########
File path: pkg/rbacframe/account.go
##########
@@ -31,8 +31,8 @@ type Account struct {
Name string `json:"name,omitempty"`
Password string `json:"password,omitempty"`
Roles []string `json:"roles,omitempty"`
- TokenExpirationTime string `json:"tokenExpirationTime,omitempty"`
- CurrentPassword string `json:"currentPassword,omitempty"`
+ TokenExpirationTime string `json:"tokenExpirationTime,omitempty" bson:"token_expiration_time"`
Review comment:
这个结构体应该切换到cari里的结构体，见#812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org