You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ywkaras (via GitHub)" <gi...@apache.org> on 2024/04/17 00:54:08 UTC
[PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
ywkaras opened a new pull request, #11259:
URL: https://github.com/apache/trafficserver/pull/11259
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11259:
URL: https://github.com/apache/trafficserver/pull/11259#issuecomment-2253047013
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #11259:
URL: https://github.com/apache/trafficserver/pull/11259#discussion_r1571658246
##########
include/proxy/http/remap/PluginFactory.h:
##########
@@ -31,8 +31,6 @@
#include "proxy/http/remap/PluginDso.h"
#include "proxy/http/remap/RemapPluginInfo.h"
-#include "tscore/Ptr.h"
Review Comment:
Unrelated cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras merged PR #11259:
URL: https://github.com/apache/trafficserver/pull/11259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #11259:
URL: https://github.com/apache/trafficserver/pull/11259#issuecomment-2065440883
The plugin load unit tests are not currently working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Raise unit tests for src/proxy/http/remap from the dead. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #11259:
URL: https://github.com/apache/trafficserver/pull/11259#discussion_r1571658246
##########
include/proxy/http/remap/PluginFactory.h:
##########
@@ -31,8 +31,6 @@
#include "proxy/http/remap/PluginDso.h"
#include "proxy/http/remap/RemapPluginInfo.h"
-#include "tscore/Ptr.h"
Review Comment:
Unrelated cleanup (same file included twice).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org