[GitHub] [arrow-rs] alexandreyc commented on pull request #4206: Add RecordBatchWriter trait and implement it for CSV, JSON, IPC and P…

["alexandreyc (via GitHub)" <gi...@apache.org>]

alexandreyc commented on PR #4206:
URL: https://github.com/apache/arrow-rs/pull/4206#issuecomment-1545601795

   I'm not sure we absolutely need a schema method.
   
   First, the caller should already know the schema since it gives the writer `RecordBatch`s which have a schema.
   
   Second, it would be a bigger refactoring because the schema is not directly available on the writer object for `arrow_ipc::writer::StreamWriter`, `arrow_csv::writer::Writer` and `arrow_json::writer::Writer`.
   
   Additionally, I wonder if we shouldn't add a deprecated attribute to the original `write` method on the writer object?
   
   What's your opinion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org