You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okuc <gi...@git.apache.org> on 2016/03/09 10:45:58 UTC
[GitHub] incubator-tinkerpop pull request: When hosts configured incorrectl...
GitHub user okuc opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/253
When hosts configured incorrectly, causing problems not connect services
When hosts configuration file, the corresponding configuration of the machine name wrong ip, cause problems not connect services
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/okuc/incubator-tinkerpop patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 308033382b6c2c0785f4416917fbcf492ec616e5
Author: okuc <ok...@users.noreply.github.com>
Date: 2016-03-09T09:45:27Z
When hosts configured incorrectly, causing problems not connect services
When hosts configuration file, the corresponding configuration of the machine name wrong ip, cause problems not connect services
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: When hosts configured incorrectl...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/253#issuecomment-194294442
This is probably a good fix, but as you can see Travis is failing the build of your branch:
https://travis-ci.org/apache/incubator-tinkerpop/builds/114736921
```text
Failed tests:
HostTest.shouldConstructHost:38 expected:<ws://[localhost]:8182/gremlin> but was:<ws://[127.0.0.1]:8182/gremlin>
```
Seems easy enough to fix that. Also, did you try running the gremlin server integration tests? those are very important to ensure that nothing breaks in this change. You just run:
```text
mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests
```
Finally, can you please give an example of not configuring the hosts correctly? I currently get this:
```text
gremlin> cluster = Cluster.open('conf/remote.yaml')
localhostdfadf: unknown error
Display stack trace? [yN] y
java.lang.IllegalArgumentException: localhostdfadf: unknown error
at org.apache.tinkerpop.gremlin.driver.Cluster$Builder.addContactPoint(Cluster.java:546)
at org.apache.tinkerpop.gremlin.driver.Cluster$Builder.<init>(Cluster.java:297)
at org.apache.tinkerpop.gremlin.driver.Cluster$Builder.<init>(Cluster.java:268)
at org.apache.tinkerpop.gremlin.driver.Cluster.build(Cluster.java:143)
at org.apache.tinkerpop.gremlin.driver.Cluster.open(Cluster.java:199)
at org.apache.tinkerpop.gremlin.driver.Cluster$open.call(Unknown Source)
```
Is that what you see? Can you show an example of what you get with your change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: When hosts configured incorrectl...
Posted by okuc <gi...@git.apache.org>.
Github user okuc closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: When hosts configured incorrectl...
Posted by okuc <gi...@git.apache.org>.
Github user okuc commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/253#issuecomment-194830804
I'm very sorry, I will correct this error until the perfect test passed, and re-submit it as required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---