You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/26 23:09:11 UTC

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13136


Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................

IMPALA-8465: fix TestJsonEndpoints for remote clusters

ImpalaCluster does not work for remote clusters, and
the patch introduced a dependency on it for a test that previously
didn't depend on it.

This reverts to the old logic for non-dockerized clusters.

Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
---
M tests/hs2/test_json_endpoints.py
1 file changed, 9 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13136/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4107/


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 01:09:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Apr 2019 22:02:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................

IMPALA-8465: fix TestJsonEndpoints for remote clusters

ImpalaCluster does not work for remote clusters, and
the patch introduced a dependency on it for a test that previously
didn't depend on it.

This reverts to the old logic for non-dockerized clusters.

Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Reviewed-on: http://gerrit.cloudera.org:8080/13136
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/hs2/test_json_endpoints.py
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4091/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:09:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 3:

I believe this should fix the issue you were seeing with this test on remote clusters.


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:48:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4091/


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Apr 2019 04:33:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 23:47:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 05:50:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 3: Code-Review+2

Thanks for the quick fix!


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:58:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2946/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:33:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4095/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Apr 2019 16:47:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 1:

The precommit should test both code paths.


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:09:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 10:45:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4107/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 23:47:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8465: fix TestJsonEndpoints for remote clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13136 )

Change subject: IMPALA-8465: fix TestJsonEndpoints for remote clusters
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4111/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cf6ecfb72ec18be0b5274e360825fb3f203dd20
Gerrit-Change-Number: 13136
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 05:50:48 +0000
Gerrit-HasComments: No