You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/08/10 23:05:00 UTC
[jira] [Commented] (CASSANDRA-16835) Scrub still uses "row" to mean
"partitions", and has broken code
[ https://issues.apache.org/jira/browse/CASSANDRA-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396932#comment-17396932 ]
Ekaterina Dimitrova commented on CASSANDRA-16835:
-------------------------------------------------
[3.11|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:16835-3.11?expand=1], [4.0|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:16835-4.0?expand=1] patches.
The trunk patch will be identical with 4.0.
I ran the respective tests locally for now. I didn't clean unrelated warnings as I didn't want to overwhelm the patch at this point with unrelated changes but if a reviewer insists, I can add that later too.
I will also run full CI pre-commit.
> Scrub still uses "row" to mean "partitions", and has broken code
> ----------------------------------------------------------------
>
> Key: CASSANDRA-16835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16835
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.x
>
>
> 2 issues in the scrub code:
> 1) It still uses "row" to mean "partition". And not only in the code, but also in user messages. As we've fairly systematically remove such instances elsewhere in 3.0+, having it in scrub is going to confuse users which will almost surely misinterpret the results. If scrub says that it dropped 2 unreadable "rows" from your sstable, you might be ok with that when we're actually talking about CQL rows, but not if we talk of 2 full partitions.
> 2) There is a branch at the end of scrub that is supposed to handle the case where scrubbing a sstable generates no output at all (the sstable is completely hosed usually), mostly providing a more user friendly message. The code is broken (and has been for a long time, since CASSANDRA-7066 I believe) however such that this branch can simply never be taken (even when it should). While admittedly pretty minor, no reason to leave it that way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org