IconRenderer

[Jeanne Waldman <je...@oracle.com>]

Does anyone know why we have 2 IconRenderers... one in
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non Faces-major 
package)

and one in
package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml; 
(Faces-major package)

I can't tell if the non-Faces-major one is being used anywhere.

Can I delete the non-Faces-major one?

Thanks,
Jeanne

Re: IconRenderer

[Adam Winer <aw...@gmail.com>]

A new shuttle renderer would be a biiiiig improvement...  I think
a lot of code is mostly still necessary because of that one renderer.

BTW, if you run the build in Maven after deleting something
like IconRenderer, you'll get a failure running the CoreRenderKitTest;
so even though this class is dynamically loaded, there's good
safeguards in place to make sure we won't delete anything that
is still used.

-- Adam


On 9/12/06, Simon Lessard <si...@gmail.com> wrote:
>
> Good to know, I'll add that renderer on the TODO list. I think there's
> also
> the processChoiceBar that need one.
>
> On 9/12/06, Jeanne Waldman <je...@oracle.com> wrote:
> >
> > I see now what the old IconRenderer is used for; the shuttle renderers
> > are not
> > yet faces-major and they use the old IconRenderer code.
> >
> > Simon Lessard wrote:
> >
> > > We have many old renderers in the ui package system that are not used
> > > anymore and could be cleared, but I don't know if adam want to do that
> > > already. I guess you could delete it if it prevents compilation, else
> it
> > > don't hurt to stay there until we kill the whole package tree, or at
> > > least
> > > until Adam is back.
> > >
> > >
> > > Regards,
> > >
> > > ~ Simon
> > >
> > > On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
> > >
> > >>
> > >> Does anyone know why we have 2 IconRenderers... one in
> > >> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
> Faces-major
> > >> package)
> > >>
> > >> and one in
> > >> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> > >> (Faces-major package)
> > >>
> > >> I can't tell if the non-Faces-major one is being used anywhere.
> > >>
> > >> Can I delete the non-Faces-major one?
> > >>
> > >> Thanks,
> > >> Jeanne
> > >>
> > >>
> > >>
> > >
> >
> >
>
>

Re: IconRenderer

[Simon Lessard <si...@gmail.com>]

Good to know, I'll add that renderer on the TODO list. I think there's also
the processChoiceBar that need one.

On 9/12/06, Jeanne Waldman <je...@oracle.com> wrote:
>
> I see now what the old IconRenderer is used for; the shuttle renderers
> are not
> yet faces-major and they use the old IconRenderer code.
>
> Simon Lessard wrote:
>
> > We have many old renderers in the ui package system that are not used
> > anymore and could be cleared, but I don't know if adam want to do that
> > already. I guess you could delete it if it prevents compilation, else it
> > don't hurt to stay there until we kill the whole package tree, or at
> > least
> > until Adam is back.
> >
> >
> > Regards,
> >
> > ~ Simon
> >
> > On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
> >
> >>
> >> Does anyone know why we have 2 IconRenderers... one in
> >> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non Faces-major
> >> package)
> >>
> >> and one in
> >> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> >> (Faces-major package)
> >>
> >> I can't tell if the non-Faces-major one is being used anywhere.
> >>
> >> Can I delete the non-Faces-major one?
> >>
> >> Thanks,
> >> Jeanne
> >>
> >>
> >>
> >
>
>

Re: IconRenderer

[Jeanne Waldman <je...@oracle.com>]

I see now what the old IconRenderer is used for; the shuttle renderers 
are not
yet faces-major and they use the old IconRenderer code.

Simon Lessard wrote:

> We have many old renderers in the ui package system that are not used
> anymore and could be cleared, but I don't know if adam want to do that
> already. I guess you could delete it if it prevents compilation, else it
> don't hurt to stay there until we kill the whole package tree, or at 
> least
> until Adam is back.
>
>
> Regards,
>
> ~ Simon
>
> On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
>>
>> Does anyone know why we have 2 IconRenderers... one in
>> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non Faces-major
>> package)
>>
>> and one in
>> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
>> (Faces-major package)
>>
>> I can't tell if the non-Faces-major one is being used anywhere.
>>
>> Can I delete the non-Faces-major one?
>>
>> Thanks,
>> Jeanne
>>
>>
>>
>

Re: IconRenderer

[Simon Lessard <si...@gmail.com>]

We have many old renderers in the ui package system that are not used
anymore and could be cleared, but I don't know if adam want to do that
already. I guess you could delete it if it prevents compilation, else it
don't hurt to stay there until we kill the whole package tree, or at least
until Adam is back.


Regards,

~ Simon

On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
> Does anyone know why we have 2 IconRenderers... one in
> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non Faces-major
> package)
>
> and one in
> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> (Faces-major package)
>
> I can't tell if the non-Faces-major one is being used anywhere.
>
> Can I delete the non-Faces-major one?
>
> Thanks,
> Jeanne
>
>
>

Re: embed key in Icon API - nix it?

[Jeanne Waldman <je...@oracle.com>]

I'm going to hold off on this. It seems to be used more than I thought, 
and it isn't necessary for my work
after all.
I do think we should get rid of the ALIGN constant, since the html align 
attribute is deprecated,
but this is a clean-up task.

- Jeanne

Simon Lessard wrote:

> +1
>
> On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
>>
>> I really doubt that anyone is using the embed property that is in the
>> TextIcon code.
>> The only renderer I see that is using it is the IconRenderer.
>> As part of the work to create <span> with attributes from the renderer
>> and <img>/Text with attributes
>> from the skinning definition, I'd like to get rid of the embed property
>> that is in the TextIcon.
>> Any objections? This is a private API right now, which is why I doubt it
>> is being used.
>>
>> - Jeanne
>>
>> Jeanne Waldman wrote:
>>
>> > Does anyone know why we have 2 IconRenderers... one in
>> > org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
>> > Faces-major package)
>> >
>> > and one in
>> > package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
>> > (Faces-major package)
>> >
>> > I can't tell if the non-Faces-major one is being used anywhere.
>> >
>> > Can I delete the non-Faces-major one?
>> >
>> > Thanks,
>> > Jeanne
>> >
>> >
>> >
>>
>>
>

Re: embed key in Icon API - nix it?

[Simon Lessard <si...@gmail.com>]

+1

On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
> I really doubt that anyone is using the embed property that is in the
> TextIcon code.
> The only renderer I see that is using it is the IconRenderer.
> As part of the work to create <span> with attributes from the renderer
> and <img>/Text with attributes
> from the skinning definition, I'd like to get rid of the embed property
> that is in the TextIcon.
> Any objections? This is a private API right now, which is why I doubt it
> is being used.
>
> - Jeanne
>
> Jeanne Waldman wrote:
>
> > Does anyone know why we have 2 IconRenderers... one in
> > org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
> > Faces-major package)
> >
> > and one in
> > package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> > (Faces-major package)
> >
> > I can't tell if the non-Faces-major one is being used anywhere.
> >
> > Can I delete the non-Faces-major one?
> >
> > Thanks,
> > Jeanne
> >
> >
> >
>
>

embed key in Icon API - nix it?

[Jeanne Waldman <je...@oracle.com>]

I really doubt that anyone is using the embed property that is in the 
TextIcon code.
The only renderer I see that is using it is the IconRenderer.
As part of the work to create <span> with attributes from the renderer 
and <img>/Text with attributes
from the skinning definition, I'd like to get rid of the embed property 
that is in the TextIcon.
Any objections? This is a private API right now, which is why I doubt it 
is being used.

- Jeanne

Jeanne Waldman wrote:

> Does anyone know why we have 2 IconRenderers... one in
> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non 
> Faces-major package)
>
> and one in
> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml; 
> (Faces-major package)
>
> I can't tell if the non-Faces-major one is being used anywhere.
>
> Can I delete the non-Faces-major one?
>
> Thanks,
> Jeanne
>
>
>