[GitHub] [pinot] walterddr commented on a diff in pull request #10918: [multistage] Add TPC-H Test for Multistage Engine

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10918:
URL: https://github.com/apache/pinot/pull/10918#discussion_r1245506688


##########
pinot-integration-tests/src/test/resources/examples/batch/tpch/customer/customer_offline_table_config.json:
##########
@@ -0,0 +1,27 @@
+{

Review Comment:
   Let's make this symlink to the pinot-tools resource folder similar to the SSB integration test case



##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -548,7 +548,7 @@ protected void setUpH2Connection()
   protected void setUpH2Connection(List<File> avroFiles)
       throws Exception {
     setUpH2Connection();
-    ClusterIntegrationTestUtils.setUpH2TableWithAvro(avroFiles, getTableName(), _h2Connection);
+    ClusterIntegrationTestUtils.setUpH2TableWithAvro(avroFiles, getTableName(), _h2Connection, getSchema());

Review Comment:
   looks like base class changes broke some other test please kindly take a look



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org