[GitHub] [incubator-doris] imay commented on a change in pull request #2276: Use dynamic_pointer_cast when cast shared_ptr to shared_ptr

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2276: Use dynamic_pointer_cast when cast shared_ptr<Base> to shared_ptr<Derived>
URL: https://github.com/apache/incubator-doris/pull/2276#discussion_r349518094
 
 

 ##########
 File path: be/src/olap/rowset/beta_rowset.cpp
 ##########
 @@ -97,11 +101,13 @@ OLAPStatus BetaRowset::remove() {
 OLAPStatus BetaRowset::link_files_to(const std::string& dir, RowsetId new_rowset_id) {
     for (int i = 0; i < num_segments(); ++i) {
         std::string dst_link_path = segment_file_path(dir, new_rowset_id, i);
+        // TODO(lingbin): use Env API? or EnvUtil?
         if (FileUtils::check_exist(dst_link_path)) {
             LOG(WARNING) << "failed to create hard link, file already exist: " << dst_link_path;
             return OLAP_ERR_FILE_ALREADY_EXIST;
         }
         std::string src_file_path = segment_file_path(_rowset_path, rowset_id(), i);
+        // TODO(lingbin): how bos support link? use copy? or keep refcount to avoid being delete?
 
 Review comment:
   What is bos? Can we change bos to external storage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org