You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2017/01/17 16:37:00 UTC

[GitHub] activemq-artemis pull request #965: NO-JIRA Rename deleteOnNoConsumers throu...

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/965

    NO-JIRA Rename deleteOnNoConsumers throughout

    The name "deleteOnNoConsumers" isn't a good match for the semantics underneath.
    The name "purgeOnNoConsumers" (and variants) is a better fit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #965
    
----
commit 16e1ad59ca9c9e252af8aa54a6450fb3922130d1
Author: Justin Bertram <jb...@apache.org>
Date:   2017-01-17T15:49:32Z

    NO-JIRA Rename deleteOnNoConsumers throughout
    
    The name "deleteOnNoConsumers" isn't a good match for the semantics underneath.
    The name "purgeOnNoConsumers" (and variants) is a better fit.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #965: Couple of fixes

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/965
  
    Failure looks unrelated to my changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #965: Couple of fixes

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/965


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #965: NO-JIRA Rename deleteOnNoConsumers throughout

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/965
  
    Instead of NO-JIRA, use the previous JIRA used for refactoring the address?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---