You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by el...@apache.org on 2012/10/04 04:06:57 UTC
svn commit: r1393878 - in
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt
src/test/java/org/apache/hadoop/security/TestPermission.java
Author: eli
Date: Thu Oct 4 02:06:56 2012
New Revision: 1393878
URL: http://svn.apache.org/viewvc?rev=1393878&view=rev
Log:
HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1393878&r1=1393877&r2=1393878&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Thu Oct 4 02:06:56 2012
@@ -137,6 +137,9 @@ Trunk (Unreleased)
HDFS-3880. Use Builder to build RPC server in HDFS.
(Brandon Li vias suresh)
+ HDFS-2127. Add a test that ensure AccessControlExceptions contain
+ a full path. (Stephen Chu via eli)
+
OPTIMIZATIONS
BUG FIXES
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java?rev=1393878&r1=1393877&r2=1393878&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java Thu Oct 4 02:06:56 2012
@@ -166,7 +166,7 @@ public class TestPermission {
}
@Test
- public void testFilePermision() throws Exception {
+ public void testFilePermission() throws Exception {
final Configuration conf = new HdfsConfiguration();
conf.setBoolean(DFSConfigKeys.DFS_PERMISSIONS_ENABLED_KEY, true);
MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).numDataNodes(3).build();
@@ -244,6 +244,10 @@ public class TestPermission {
fs.mkdirs(p);
return true;
} catch(AccessControlException e) {
+ // We check that AccessControlExceptions contain absolute paths.
+ Path parent = p.getParent();
+ assertTrue(parent.isUriPathAbsolute());
+ assertTrue(e.getMessage().contains(parent.toString()));
return false;
}
}
@@ -253,6 +257,9 @@ public class TestPermission {
fs.create(p);
return true;
} catch(AccessControlException e) {
+ Path parent = p.getParent();
+ assertTrue(parent.isUriPathAbsolute());
+ assertTrue(e.getMessage().contains(parent.toString()));
return false;
}
}
@@ -262,6 +269,8 @@ public class TestPermission {
fs.open(p);
return true;
} catch(AccessControlException e) {
+ assertTrue(p.isUriPathAbsolute());
+ assertTrue(e.getMessage().contains(p.toString()));
return false;
}
}
@@ -272,6 +281,9 @@ public class TestPermission {
fs.rename(src, dst);
return true;
} catch(AccessControlException e) {
+ Path parent = dst.getParent();
+ assertTrue(parent.isUriPathAbsolute());
+ assertTrue(e.getMessage().contains(parent.toString()));
return false;
}
}