You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by ga...@gmail.com on 2010/10/12 11:54:38 UTC

Re: BugFix - optimizer config is not respecting the compression ratio specified. (issue2319044)

Change looks good, but 1 question:
Where do the tests pick their compression value from: the value set in
shindig.properties, or the default value set in OptimizerConfig()
constructor ?

Also, maybe you should add an image with compression quality as say 70%
to make sure that we really fixed the bug.

Thanks for figuring out and fixing the awesome bug :)

http://codereview.appspot.com/2319044/