You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/02/24 13:19:58 UTC
[GitHub] [mynewt-nimble] supperthomas opened a new pull request #1189: nimble/hs: fix the LE Supported feature mask
supperthomas opened a new pull request #1189:
URL: https://github.com/apache/mynewt-nimble/pull/1189
when set the features we set the htole64 in
ble_ll_hci.c.It will match the value about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] supperthomas commented on a change in pull request #1189: nimble/hs: fix the LE Supported feature mask
Posted by GitBox <gi...@apache.org>.
supperthomas commented on a change in pull request #1189:
URL: https://github.com/apache/mynewt-nimble/pull/1189#discussion_r813939636
##########
File path: nimble/host/src/ble_hs_startup.c
##########
@@ -40,7 +40,7 @@ ble_hs_startup_read_sup_f_tx(void)
/* for now we don't use it outside of init sequence so check this here
* LE Supported (Controller) byte 4, bit 6
*/
- if (!(rsp.features & 0x0000006000000000)) {
+ if (!(rsp.features & htole64(0x0000006000000000))) {
Review comment:
complete .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1189: nimble/hs: fix the LE Supported feature mask
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #1189:
URL: https://github.com/apache/mynewt-nimble/pull/1189#discussion_r813896038
##########
File path: nimble/host/src/ble_hs_startup.c
##########
@@ -40,7 +40,7 @@ ble_hs_startup_read_sup_f_tx(void)
/* for now we don't use it outside of init sequence so check this here
* LE Supported (Controller) byte 4, bit 6
*/
- if (!(rsp.features & 0x0000006000000000)) {
+ if (!(rsp.features & htole64(0x0000006000000000))) {
Review comment:
Hi,
I think it would be cleaner to do other way around:
if (!(le64toh(rsp.features) & 0x0000006000000000))) {
that way constant is used in host order, while LE value is converted to host before use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1189: nimble/hs: fix the LE Supported feature mask
Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #1189:
URL: https://github.com/apache/mynewt-nimble/pull/1189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org