You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2007/11/26 23:17:43 UTC

[jira] Created: (AXIS2-3367) Performance: JAX-WS MessageContext getProperty/setProperty improvement

Performance: JAX-WS MessageContext getProperty/setProperty improvement
----------------------------------------------------------------------

                 Key: AXIS2-3367
                 URL: https://issues.apache.org/jira/browse/AXIS2-3367
             Project: Axis 2.0 (Axis2)
          Issue Type: Improvement
          Components: jaxws
            Reporter: Rich Scheuerle
            Assignee: Rich Scheuerle


The JAX-WS MessageContext uses the local map on the Axis2 MessageContext to store properties.
This code was written prior to the Axis2 MC property redesign, and should be improved.

For example the current getProperty code is:

public Object getProperty(String key) {
        if (DELEGATE_TO_AXISMC) {
            // only use properties that are local to the axis2 MC,
            // not the options bag.  See org.apache.axis2.context.AbstractContext
            Iterator names = axisMsgCtx.getPropertyNames();
            for (; names.hasNext();) {
                String name = (String)names.next();
                if (name.equals(key)) {
                    return axisMsgCtx.getProperty(key);
                }
            }
            return null;
        }
        return getProperties().get(key);
    }

The new code will be:

public Object getProperty(String key) {
        if (DELEGATE_TO_AXISMC) {
            // only use properties that are local to the axis2 MC,
            return axisMsgCtx.getLocalProperty(key);
        }
        return getProperties().get(key);
    }

Kudos to David Strite (IBM) for finding this improvement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-3367) Performance: JAX-WS MessageContext getProperty/setProperty improvement

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle resolved AXIS2-3367.
-----------------------------------

    Resolution: Fixed

Committed revision 598734.

Fixed the reported issue and cleaned up some related areas.

> Performance: JAX-WS MessageContext getProperty/setProperty improvement
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3367
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3367
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: jaxws
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> The JAX-WS MessageContext uses the local map on the Axis2 MessageContext to store properties.
> This code was written prior to the Axis2 MC property redesign, and should be improved.
> For example the current getProperty code is:
> public Object getProperty(String key) {
>         if (DELEGATE_TO_AXISMC) {
>             // only use properties that are local to the axis2 MC,
>             // not the options bag.  See org.apache.axis2.context.AbstractContext
>             Iterator names = axisMsgCtx.getPropertyNames();
>             for (; names.hasNext();) {
>                 String name = (String)names.next();
>                 if (name.equals(key)) {
>                     return axisMsgCtx.getProperty(key);
>                 }
>             }
>             return null;
>         }
>         return getProperties().get(key);
>     }
> The new code will be:
> public Object getProperty(String key) {
>         if (DELEGATE_TO_AXISMC) {
>             // only use properties that are local to the axis2 MC,
>             return axisMsgCtx.getLocalProperty(key);
>         }
>         return getProperties().get(key);
>     }
> Kudos to David Strite (IBM) for finding this improvement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org