You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/04/14 12:42:46 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1438: feat(new_metrics): add backup-policy-level metric entity and migrate backup-policy-level metrics for meta_backup_service
empiredan opened a new pull request, #1438:
URL: https://github.com/apache/incubator-pegasus/pull/1438
https://github.com/apache/incubator-pegasus/issues/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1438: feat(new_metrics): add backup-policy-level metric entity and migrate backup-policy-level metrics for meta_backup_service
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1438:
URL: https://github.com/apache/incubator-pegasus/pull/1438#discussion_r1167471590
##########
src/meta/meta_backup_service.cpp:
##########
@@ -830,12 +862,8 @@ void policy_context::start()
continue_current_backup_unlocked();
}
- std::string counter_name = _policy.policy_name + ".recent.backup.duration(ms)";
- _counter_policy_recent_backup_duration_ms.init_app_counter(
- "eon.meta.policy",
- counter_name.c_str(),
- COUNTER_TYPE_NUMBER,
- "policy recent backup duration time");
+ CHECK(!(_policy.policy_name.empty()), "policy_name should has been initialized");
Review Comment:
```suggestion
CHECK(!_policy.policy_name.empty(), "policy_name should has been initialized");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1438: feat(new_metrics): add backup-policy-level metric entity and migrate backup-policy-level metrics for meta_backup_service
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1438:
URL: https://github.com/apache/incubator-pegasus/pull/1438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org