[GitHub] [systemml] kev-inn commented on a change in pull request #946: Privacy Runtime Extended

[GitBox <gi...@apache.org>]

kev-inn commented on a change in pull request #946:
URL: https://github.com/apache/systemml/pull/946#discussion_r445086179



##########
File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java
##########
@@ -74,4 +80,16 @@ public int getNumParams() {
 	public FederatedRequest deepClone() {
 		return new FederatedRequest(_method, new ArrayList<>(_data));
 	}
+
+	public void setCheckPrivacy(boolean checkPrivacy){
+		this.checkPrivacy = checkPrivacy;
+	}
+
+	public void setCheckPrivacy(){
+		setCheckPrivacy(DMLScript.CHECK_PRIVACY);
+	}
+
+	public boolean checkPrivacy(){
+		return checkPrivacy;
+	}

Review comment:
       would `getCheckPrivacy` maybe be more consistent with the `set`? Would be fine with both, just throwing it out there.

##########
File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java
##########
@@ -56,10 +65,45 @@ public boolean isSuccessful() {
 	}
 	
 	public String getErrorMessage() {
-		return (String) _data[0];
+		return ExceptionUtils.getFullStackTrace( (Exception) _data[0] );
 	}
 	
-	public Object[] getData() {
+	public Object[] getData() throws Exception {
+		updateCheckedConstraintsLog();
+		if ( !isSuccessful() )
+			throwExceptionFromResponse(); 

Review comment:
       Big fan of this :+1:

##########
File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java
##########
@@ -33,20 +35,24 @@
 	
 	private FedMethod _method;
 	private List<Object> _data;
+	private boolean checkPrivacy;

Review comment:
       could we prepend it with `_` so the variables have the same format?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org