You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2010/05/21 17:25:19 UTC
Port tomcat-juli.jar handling from TC6 to TC7
There is a feature in TC6, which implementation differs from TC7:
"Allow per instance configuration of JULI or log4j for core Tomcat
logging when using CATALINA_BASE."
It was implemented in tc6.0.x by r885002
http://svn.apache.org/viewvc?rev=885002&view=rev
I want to revert current implementation of the feature in trunk and
port the implementation from TC6 (r885002).
Are there any objections?
The essence is that bootstrap.jar will mention tomcat-juli.jar in its
"Class-Path" value in its MANIFEST.MF.
It does not mention it in the current trunk.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Port tomcat-juli.jar handling from TC6 to TC7
Posted by Mark Thomas <ma...@apache.org>.
On 21/05/2010 17:11, Konstantin Kolinko wrote:
> 2010/5/21 Mark Thomas <ma...@apache.org>:
>>> Are there any objections?
>> Yes.
>>
>>> The essence is that bootstrap.jar will mention tomcat-juli.jar in its
>>> "Class-Path" value in its MANIFEST.MF.
>>
>> This was a hack we used to keep Eclipse happy. It doesn't serve any
>> other purpose.
>>
>
> Eclipse was just an example, that things are broking by that change.
> Not everybody uses catalina.bat/sh.
>
> It is just that I do not like removing features without proper justification.
>
> Besides that I know of the following:
> a) I am able to start Tomcat 6 by running java -jar bootstrap.jar
Which will be broken because you aren't using JULI to provide the
LogManager.
> b) JSVC documentation says to use jsvc -cp bootstrap.jar
> http://tomcat.apache.org/tomcat-6.0-doc/setup.html#Unix%20daemon
> http://tomcat.apache.org/tomcat-5.5-doc/setup.html#Unix%20daemon
Looks like that needs fixing then.
> Though, I should say that
> Re: "a)": It is not an important use case.
Agreed.
> Re: "b)": There are scripts that explicitly build a CLASSPATH for jsvc, e.g.
> - in a recent e-mail
> http://marc.info/?l=tomcat-user&m=127411783204054&w=2
> - found by Googling (this one is said to be for 5.0)
> https://wiki.ucar.edu/display/esgcet/Jsvc+Script+Example
>
>
>> has caused at least one
>> support issue for one of our customers.
>
> This sound bad.
>
>
> Well, if your concerns are really serious and we go this way, let's
> 1. Remove commons-daemon.jar reference from bootstrap.jar manifest as well.
> 2. Update JSVC instructions in setup.html
+1.
Mark
>
> AFAIK, the commons-daemon.jar is not needed unless we run with jsvc.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Port tomcat-juli.jar handling from TC6 to TC7
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/21 Mark Thomas <ma...@apache.org>:
>> Are there any objections?
> Yes.
>
>> The essence is that bootstrap.jar will mention tomcat-juli.jar in its
>> "Class-Path" value in its MANIFEST.MF.
>
> This was a hack we used to keep Eclipse happy. It doesn't serve any
> other purpose.
>
Eclipse was just an example, that things are broking by that change.
Not everybody uses catalina.bat/sh.
It is just that I do not like removing features without proper justification.
Besides that I know of the following:
a) I am able to start Tomcat 6 by running java -jar bootstrap.jar
b) JSVC documentation says to use jsvc -cp bootstrap.jar
http://tomcat.apache.org/tomcat-6.0-doc/setup.html#Unix%20daemon
http://tomcat.apache.org/tomcat-5.5-doc/setup.html#Unix%20daemon
Though, I should say that
Re: "a)": It is not an important use case.
Re: "b)": There are scripts that explicitly build a CLASSPATH for jsvc, e.g.
- in a recent e-mail
http://marc.info/?l=tomcat-user&m=127411783204054&w=2
- found by Googling (this one is said to be for 5.0)
https://wiki.ucar.edu/display/esgcet/Jsvc+Script+Example
> has caused at least one
> support issue for one of our customers.
This sound bad.
Well, if your concerns are really serious and we go this way, let's
1. Remove commons-daemon.jar reference from bootstrap.jar manifest as well.
2. Update JSVC instructions in setup.html
AFAIK, the commons-daemon.jar is not needed unless we run with jsvc.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Port tomcat-juli.jar handling from TC6 to TC7
Posted by Mark Thomas <ma...@apache.org>.
On 21/05/2010 16:25, Konstantin Kolinko wrote:
> There is a feature in TC6, which implementation differs from TC7:
> "Allow per instance configuration of JULI or log4j for core Tomcat
> logging when using CATALINA_BASE."
>
> It was implemented in tc6.0.x by r885002
> http://svn.apache.org/viewvc?rev=885002&view=rev
>
> I want to revert current implementation of the feature in trunk and
> port the implementation from TC6 (r885002).
> Are there any objections?
Yes.
> The essence is that bootstrap.jar will mention tomcat-juli.jar in its
> "Class-Path" value in its MANIFEST.MF.
This was a hack we used to keep Eclipse happy. It doesn't serve any
other purpose.
> It does not mention it in the current trunk.
Having the unecessary reference in the MANIFEST has caused at least one
support issue for one of our customers. I am very reluctant to add this
back in trunk. I could be pursuaded if there is a really good reason but
it would have to be a very good reason.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org