[GitHub] [flink] zhengcanbin commented on a change in pull request #11707: [FLINK-15648][k8s] Introduce CPU limit support for JM/TM Container

[GitBox <gi...@apache.org>]

zhengcanbin commented on a change in pull request #11707: [FLINK-15648][k8s] Introduce CPU limit support for JM/TM Container
URL: https://github.com/apache/flink/pull/11707#discussion_r407298631
 
 

 ##########
 File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
 ##########
 @@ -122,19 +123,35 @@ public static String getDeploymentName(String clusterId) {
 	 * Get resource requirements from memory and cpu.
 	 *
 	 * @param mem Memory in mb.
-	 * @param cpu cpu.
+	 * @param cpuRequest cpu request.
 
 Review comment:
   > For standardization, could you please capitalize it as "CPU"?
   Thanks for pointing out this, the new commit fix it.
   
   > Also please pay attention to its plural form, like "number of cpu", as it should be "number of CPUs" in the description text.
   They are not introduced by this PR and indeed are not in the scope.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services